gecko-dev/dom/svg/SVGFEPointLightElement.h
Nathan Froyd 846d8789ee Bug 1492894 - part 1 - make the node hierarchy consistently constructed with NodeInfo&&; r=mccr8
Various places in dom/ use the pattern:

  already_AddRefed<NodeInfo> ni = ...;

which is supposed to be disallowed by our static analysis code, but
isn't, for whatever reason.  To fix our static analysis code, we need to
eliminate instances of the above pattern.

Unfortunately, eliminating this pattern requires restructuring how Nodes
are created.  Most Node subclasses take `already_AddRefed<NodeInfo>&` in
their constructors, and a few accept `already_AddRefed<NodeInfo>&&`.  We
need to enforce the latter pattern consistently, which requires changing
dozens of source files.
2018-09-21 16:45:49 -04:00

57 lines
2.0 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_dom_SVGFEPointLightElement_h
#define mozilla_dom_SVGFEPointLightElement_h
#include "nsSVGFilters.h"
#include "nsSVGNumber2.h"
nsresult NS_NewSVGFEPointLightElement(nsIContent **aResult,
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo);
namespace mozilla {
namespace dom {
typedef SVGFELightElement SVGFEPointLightElementBase;
class SVGFEPointLightElement : public SVGFEPointLightElementBase
{
friend nsresult (::NS_NewSVGFEPointLightElement(nsIContent **aResult,
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo));
protected:
explicit SVGFEPointLightElement(already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo)
: SVGFEPointLightElementBase(std::move(aNodeInfo))
{
}
virtual JSObject* WrapNode(JSContext *cx, JS::Handle<JSObject*> aGivenProto) override;
public:
virtual mozilla::gfx::LightType ComputeLightAttributes(nsSVGFilterInstance* aInstance,
nsTArray<float>& aFloatAttributes) override;
virtual bool AttributeAffectsRendering(
int32_t aNameSpaceID, nsAtom* aAttribute) const override;
virtual nsresult Clone(dom::NodeInfo*, nsINode** aResult) const override;
// WebIDL
already_AddRefed<SVGAnimatedNumber> X();
already_AddRefed<SVGAnimatedNumber> Y();
already_AddRefed<SVGAnimatedNumber> Z();
protected:
virtual NumberAttributesInfo GetNumberInfo() override;
enum { ATTR_X, ATTR_Y, ATTR_Z };
nsSVGNumber2 mNumberAttributes[3];
static NumberInfo sNumberInfo[3];
};
} // namespace dom
} // namespace mozilla
#endif // mozilla_dom_SVGFEPointLightElement_h