mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-07 12:15:51 +00:00
23a0cee1a8
nsPSMUITracker was problematic. Apparently it was originally intended to prevent NSS shutdown while NSS-related UI operations were going on (such as choosing a client certificate). However, when nsNSSComponent would receive the event that told it to shutdown NSS, it would attempt to call mShutdownObjectList->evaporateAllNSSResources(), which would call mActivityState.restrictActivityToCurrentThread(), which failed if such a UI operation was in progress. This actually prevented the important part of evaporateAllNSSResources, which is the releasing of all NSS objects in use by PSM objects. Importantly, nsNSSComponent didn't check for or handle this failure and proceeded to call NSS_Shutdown(), leaving PSM in an inconsistent state where it thought it was okay to keep using the NSS objects it had when in fact it wasn't. In any case, nsPSMUITracker isn't really necessary as long as we have the nsNSSShutDownPreventionLock mechanism, which mostly works and is what we should use instead (or not at all, if no such lock is needed for the operation being performed (for example, if no NSS functions are being called)).
32 lines
842 B
C++
32 lines
842 B
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef _NSCERTPICKER_H_
|
|
#define _NSCERTPICKER_H_
|
|
|
|
#include "nsIUserCertPicker.h"
|
|
#include "nsNSSShutDown.h"
|
|
|
|
#define NS_CERT_PICKER_CID \
|
|
{ 0x735959a1, 0xaf01, 0x447e, { 0xb0, 0x2d, 0x56, 0xe9, 0x68, 0xfa, 0x52, 0xb4 } }
|
|
|
|
class nsCertPicker : public nsIUserCertPicker
|
|
, public nsNSSShutDownObject
|
|
{
|
|
public:
|
|
NS_DECL_ISUPPORTS
|
|
NS_DECL_NSIUSERCERTPICKER
|
|
|
|
nsCertPicker();
|
|
|
|
// Nothing to actually release.
|
|
virtual void virtualDestroyNSSReference() override {}
|
|
|
|
protected:
|
|
virtual ~nsCertPicker();
|
|
};
|
|
|
|
#endif //_NSCERTPICKER_H_
|