gecko-dev/netwerk/cookie
Valentin Gosu 1a1f42da37 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-11 07:10:41 +00:00
..
test Bug 1683593 - Use bracketed IPv6 address to get cookies r=baku 2021-01-27 09:07:28 +00:00
Cookie.cpp
Cookie.h
CookieCommons.cpp Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw 2021-06-04 12:35:16 +00:00
CookieCommons.h
CookieJarSettings.cpp Bug 1691907 - Part 2: Add a method initWithURI to nsICookieJarSettings. r=dimi,robwu 2021-03-31 19:54:28 +00:00
CookieJarSettings.h Bug 1695050 - Part 2: Modify CookieJarSettings::Create() to be able to creat cookieJarSettings according to the browsing mode. r=dimi,preferences-reviewers 2021-03-29 11:01:51 +00:00
CookieKey.h
CookieLogging.cpp
CookieLogging.h
CookiePersistentStorage.cpp Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw 2021-06-04 12:35:16 +00:00
CookiePersistentStorage.h
CookiePrivateStorage.cpp
CookiePrivateStorage.h
CookieService.cpp Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw 2021-06-04 12:35:16 +00:00
CookieService.h
CookieServiceChild.cpp Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika 2021-03-24 17:56:49 +00:00
CookieServiceChild.h
CookieServiceParent.cpp Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw 2021-06-04 12:35:16 +00:00
CookieServiceParent.h
CookieStorage.cpp Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw 2021-06-11 07:10:41 +00:00
CookieStorage.h Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw 2021-06-11 07:10:41 +00:00
CookieXPCShellUtils.jsm
moz.build
nsICookie.idl
nsICookieJarSettings.idl Bug 1691907 - Part 2: Add a method initWithURI to nsICookieJarSettings. r=dimi,robwu 2021-03-31 19:54:28 +00:00
nsICookieManager.idl Bug 1695050 - Part 2: Modify CookieJarSettings::Create() to be able to creat cookieJarSettings according to the browsing mode. r=dimi,preferences-reviewers 2021-03-29 11:01:51 +00:00
nsICookiePermission.idl
nsICookieService.idl
PCookieService.ipdl Bug 1689147 - Part 4: Switch nested and prio to extended attributes, r=mccr8 2021-02-09 16:50:22 +00:00