mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-04 02:57:38 +00:00
64e0a7e0fd
In order to create less WebRenderLayerScrollData currently we use a deferred transform item https://searchfox.org/mozilla-central/rev/593c49fa812ceb4be45fcea7c9e90d15f59edb70/gfx/layers/wr/StackingContextHelper.h#82 We don't need a WebRenderLayerScrollData for every transform because a lot of transforms don't contain any ASRs, so the created WebRenderLayerScrollData would be useless. However this optimization can lead to us creating a lot more WebRenderLayerScrollData later if the transform does contain ASRs. For example, if there is a transform, and then inside that is a ASR, and inside the ASR is a lot of small transforms, we end up having to create a WebRenderLayerScrollData for every little transform which don't contain any ASRs. This is doing the opposite of what the optimization intended. WebRenderLayerScrollData creation happens during the CreateWebRenderCommands phase, so the display list build phase is complete, and we can tell cheaply if a transform contains any ASRs during display list building. So we just record that and use that to inform our decision about when to defer the transform item or not. This optimization drastically reduces the total number of WebRenderLayerScrollData that we create during a full run of speedometer3 (summing the number created each paint over every paint). In my testing it went from 12-13k to 2-3k. Mostly subtests fell into two buckets: a single digit number of WebRenderLayerScrollData to begin with and this patch didn't change that, and 100 WebRenderLayerScrollData down to single digits after this patch. So the savings are concentrated in a few subtests that hit the described behaviour above. I compared a profile before and after this patch of 10 runs of speedometer3, this patch saved 100 samples/ms serializing WebRenderLayerScrollData, which was what I expected based on how long serialization took before the patch combined with how many WebRenderLayerScrollData we were avoiding. The whole run took about 100,000 samples/ms, so this should hopefully be good for about 0.1% improvment. There is also potential savings in other areas outside of serialization step but that was a little harder to measure. Differential Revision: https://phabricator.services.mozilla.com/D197446 |
||
|---|---|---|
| .. | ||
| crashtests | ||
| test | ||
| AnonymousContentKey.h | ||
| AspectRatio.cpp | ||
| AspectRatio.h | ||
| AutoCopyListener.h | ||
| BlockReflowState.cpp | ||
| BlockReflowState.h | ||
| BRFrame.cpp | ||
| broken-image.png | ||
| ColumnSetWrapperFrame.cpp | ||
| ColumnSetWrapperFrame.h | ||
| ColumnUtils.cpp | ||
| ColumnUtils.h | ||
| CSSAlignUtils.cpp | ||
| CSSAlignUtils.h | ||
| CSSOrderAwareFrameIterator.cpp | ||
| CSSOrderAwareFrameIterator.h | ||
| folder.png | ||
| frame-graph.py | ||
| FrameClass.py | ||
| FrameClasses.py | ||
| GenerateFrameLists.py | ||
| jar.mn | ||
| JustificationUtils.h | ||
| LayoutMessageUtils.h | ||
| MathMLTextRunFactory.cpp | ||
| MathMLTextRunFactory.h | ||
| MiddleCroppingBlockFrame.cpp | ||
| MiddleCroppingBlockFrame.h | ||
| moz.build | ||
| nsAbsoluteContainingBlock.cpp | ||
| nsAbsoluteContainingBlock.h | ||
| nsAtomicContainerFrame.h | ||
| nsBackdropFrame.cpp | ||
| nsBackdropFrame.h | ||
| nsBlockDebugFlags.h | ||
| nsBlockFrame.cpp | ||
| nsBlockFrame.h | ||
| nsBlockReflowContext.cpp | ||
| nsBlockReflowContext.h | ||
| nsCanvasFrame.cpp | ||
| nsCanvasFrame.h | ||
| nsColumnSetFrame.cpp | ||
| nsColumnSetFrame.h | ||
| nsContainerFrame.cpp | ||
| nsContainerFrame.h | ||
| nsContainerFrameInlines.h | ||
| nsDirection.h | ||
| nsFirstLetterFrame.cpp | ||
| nsFirstLetterFrame.h | ||
| nsFlexContainerFrame.cpp | ||
| nsFlexContainerFrame.h | ||
| nsFloatManager.cpp | ||
| nsFloatManager.h | ||
| nsFontInflationData.cpp | ||
| nsFontInflationData.h | ||
| nsFrameList.cpp | ||
| nsFrameList.h | ||
| nsFrameSelection.cpp | ||
| nsFrameSelection.h | ||
| nsFrameSetFrame.cpp | ||
| nsFrameSetFrame.h | ||
| nsFrameState.cpp | ||
| nsFrameState.h | ||
| nsFrameStateBits.h | ||
| nsGfxScrollFrame.cpp | ||
| nsGfxScrollFrame.h | ||
| nsGridContainerFrame.cpp | ||
| nsGridContainerFrame.h | ||
| nsHTMLCanvasFrame.cpp | ||
| nsHTMLCanvasFrame.h | ||
| nsHTMLParts.h | ||
| nsIAnonymousContentCreator.h | ||
| nsIFrame.cpp | ||
| nsIFrame.h | ||
| nsIFrameInlines.h | ||
| nsILineIterator.cpp | ||
| nsILineIterator.h | ||
| nsImageFrame.cpp | ||
| nsImageFrame.h | ||
| nsImageMap.cpp | ||
| nsImageMap.h | ||
| nsInlineFrame.cpp | ||
| nsInlineFrame.h | ||
| nsIntervalSet.cpp | ||
| nsIntervalSet.h | ||
| nsIScrollableFrame.h | ||
| nsIScrollPositionListener.h | ||
| nsIStatefulFrame.h | ||
| nsLeafFrame.cpp | ||
| nsLeafFrame.h | ||
| nsLineBox.cpp | ||
| nsLineBox.h | ||
| nsLineLayout.cpp | ||
| nsLineLayout.h | ||
| nsPageContentFrame.cpp | ||
| nsPageContentFrame.h | ||
| nsPageFrame.cpp | ||
| nsPageFrame.h | ||
| nsPageSequenceFrame.cpp | ||
| nsPageSequenceFrame.h | ||
| nsPlaceholderFrame.cpp | ||
| nsPlaceholderFrame.h | ||
| nsQueryFrame.h | ||
| nsRubyBaseContainerFrame.cpp | ||
| nsRubyBaseContainerFrame.h | ||
| nsRubyBaseFrame.cpp | ||
| nsRubyBaseFrame.h | ||
| nsRubyContentFrame.cpp | ||
| nsRubyContentFrame.h | ||
| nsRubyFrame.cpp | ||
| nsRubyFrame.h | ||
| nsRubyTextContainerFrame.cpp | ||
| nsRubyTextContainerFrame.h | ||
| nsRubyTextFrame.cpp | ||
| nsRubyTextFrame.h | ||
| nsSplittableFrame.cpp | ||
| nsSplittableFrame.h | ||
| nsSubDocumentFrame.cpp | ||
| nsSubDocumentFrame.h | ||
| nsTextFrame.cpp | ||
| nsTextFrame.h | ||
| nsTextFrameUtils.cpp | ||
| nsTextFrameUtils.h | ||
| nsTextPaintStyle.cpp | ||
| nsTextPaintStyle.h | ||
| nsTextRunTransformations.cpp | ||
| nsTextRunTransformations.h | ||
| nsVideoFrame.cpp | ||
| nsVideoFrame.h | ||
| PrintedSheetFrame.cpp | ||
| PrintedSheetFrame.h | ||
| ReflowInput.cpp | ||
| ReflowInput.h | ||
| ReflowOutput.cpp | ||
| ReflowOutput.h | ||
| RubyUtils.cpp | ||
| RubyUtils.h | ||
| ScrollAnchorContainer.cpp | ||
| ScrollAnchorContainer.h | ||
| ScrollAnimationBezierPhysics.cpp | ||
| ScrollAnimationBezierPhysics.h | ||
| ScrollAnimationMSDPhysics.cpp | ||
| ScrollAnimationMSDPhysics.h | ||
| ScrollAnimationPhysics.h | ||
| ScrollbarActivity.cpp | ||
| ScrollbarActivity.h | ||
| ScrollbarPreferences.h | ||
| ScrollGeneration.cpp | ||
| ScrollGeneration.h | ||
| ScrollOrigin.h | ||
| ScrollPositionUpdate.cpp | ||
| ScrollPositionUpdate.h | ||
| ScrollSnap.cpp | ||
| ScrollSnap.h | ||
| ScrollSnapInfo.cpp | ||
| ScrollSnapInfo.h | ||
| ScrollSnapTargetId.h | ||
| ScrollVelocityQueue.cpp | ||
| ScrollVelocityQueue.h | ||
| SelectionMovementUtils.cpp | ||
| SelectionMovementUtils.h | ||
| StickyScrollContainer.cpp | ||
| StickyScrollContainer.h | ||
| TextDrawTarget.h | ||
| TextOverflow.cpp | ||
| TextOverflow.h | ||
| ViewportFrame.cpp | ||
| ViewportFrame.h | ||
| Visibility.h | ||
| WBRFrame.cpp | ||
| WritingModes.h | ||
