Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
d7eecef1e9
gecko-dev/docshell/base
History
Kris Maglione d7eecef1e9 Bug 1574593: Silently ignore load attempt on/from discarded BrowsingContext. r=nika 
The (non-normative) window.open spec does not specify what should happen when
window.open is called on a window with a null/discarded browsing context, but
in general the lookup and creation rules do not make sense when the window has
no BC. It does, however, specify that we should return null when a target BC
cannot be found or created, and gives us broad discretion over when we decide
to ignore a load request and return null. Since we can't trigger a
cross-process load from a discarded BC, simply aborting in that case seems
like the logical solution.

For Location objects, the spec is more specific, and requires that we ignore
load attempts on Location objects whose documents are null, which in our
implementation corresponds to a discarded BrowsingContext.
LocationBase::SetURI already enforces this, but a second check in
BrowsingContext::LoadURI is probably a good idea as well.

Differential Revision: https://phabricator.services.mozilla.com/D45635

--HG--
extra : moz-landing-system : lando
2019-09-12 11:37:01 +00:00
..
crashtests Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE 2019-07-03 16:08:23 +03:00
timeline Bug 1571926 - Don't record timeline consumers mutex, r=froydnj. 2019-08-08 14:54:58 +00:00
BrowsingContext.cpp Bug 1574593: Silently ignore load attempt on/from discarded BrowsingContext. r=nika 2019-09-12 11:37:01 +00:00
BrowsingContext.h Bug 1560110 - Cache children of detached browsing contexts. r=nika 2019-09-10 15:37:54 +00:00
BrowsingContextFieldList.h Bug 1576407: Part 1 - Add HadOriginalOpener flag to BrowsingContext. r=farre 2019-08-28 18:07:31 +00:00
BrowsingContextGroup.cpp Bug 1566153 - P2. Clean-up BrowsingContextGroup references when empty. r=nika 2019-07-17 00:31:38 +00:00
BrowsingContextGroup.h Bug 1566153 - P2. Clean-up BrowsingContextGroup references when empty. r=nika 2019-07-17 00:31:38 +00:00
CanonicalBrowsingContext.cpp Bug 1542415: Part 2 - Treat in-flight messages from incorrect owner as warnings. r=nika 2019-09-09 11:50:35 +00:00
CanonicalBrowsingContext.h Bug 1542415: Part 2 - Treat in-flight messages from incorrect owner as warnings. r=nika 2019-09-09 11:50:35 +00:00
ChildProcessChannelListener.cpp
ChildProcessChannelListener.h
IHistory.h
LoadContext.cpp Bug 1566186: Part 1 - Remove DocShell support for isolated mozbrowsers. r=nika 2019-07-16 16:40:19 -07:00
LoadContext.h Bug 1566186: Part 1 - Remove DocShell support for isolated mozbrowsers. r=nika 2019-07-16 16:40:19 -07:00
moz.build Bug 1566215 - Part 6: Undo the insecure URI loading exception for the Layout Debugger. r=dbaron 2019-07-22 04:48:46 +00:00
nsAboutRedirector.cpp Bug 1556559 - make about:license non-web-linkable again, r=valentin 2019-06-07 12:11:34 +00:00
nsAboutRedirector.h
nsCTooltipTextProvider.h
nsDefaultURIFixup.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
nsDefaultURIFixup.h
nsDocShell.cpp Bug 1529068 - Implementation of the navigate-to CSP directive as defined in CSP Level 3. r=ckerschb,mccr8 2019-09-10 22:33:51 +00:00
nsDocShell.h Bug 1556489 - P12. Move code into static utility method. r=nika 2019-09-03 10:19:35 +10:00
nsDocShellEditorData.cpp Bug 1415270 - Part 1: Move nsHTMLDocument editing APIs to Document; r=farre,masayuki 2019-05-31 01:37:26 +00:00
nsDocShellEditorData.h Bug 836176 - Part 3: Remove nsIHTMLDocument; r=farre 2019-06-04 17:27:43 +00:00
nsDocShellEnumerator.cpp Bug 1559414 - Rename unaudited pre-fission methods with SameProcess for future audit burndown. r=nika 2019-07-26 16:48:31 +00:00
nsDocShellEnumerator.h
nsDocShellLoadState.cpp Bug 1556489 - P10. Pass PostData and Headers at DocShell creation time. r=nika,farre 2019-09-03 10:19:27 +10:00
nsDocShellLoadState.h Bug 1556489 - P5. Fix constness. r=nika 2019-09-03 10:19:09 +10:00
nsDocShellLoadTypes.h
nsDocShellTreeOwner.cpp Bug 1559414 - Rename unaudited pre-fission methods with SameProcess for future audit burndown. r=nika 2019-07-26 16:48:31 +00:00
nsDocShellTreeOwner.h Bug 1550637 - hide tooltip when the docshell navigate, don't show tooltips if the docshell is no longer active, r=nika,dao 2019-07-16 07:48:23 +00:00
nsDSURIContentListener.cpp Bug 1576407: Part 3 - Return window opener as a WindowProxyHolder or BrowsingContext. r=farre 2019-08-28 18:07:38 +00:00
nsDSURIContentListener.h
nsIContentViewer.idl Bug 1523638 - Part 9: Use provided 'WindowGlobalChild' actors to create the initial about:blank document, r=kmag 2019-08-08 16:07:12 +00:00
nsIContentViewerEdit.idl
nsIDocShell.idl Bug 1570773: Move browsingContext getter to nsIDocShellTreeItem and add notxpcom variant. r=nika 2019-08-07 16:59:30 +00:00
nsIDocShellTreeItem.idl Bug 1570773: Move browsingContext getter to nsIDocShellTreeItem and add notxpcom variant. r=nika 2019-08-07 16:59:30 +00:00
nsIDocShellTreeOwner.idl
nsIDocumentLoaderFactory.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsILoadContext.idl Bug 1566186: Part 1 - Remove DocShell support for isolated mozbrowsers. r=nika 2019-07-16 16:40:19 -07:00
nsILoadURIDelegate.idl
nsIPrivacyTransitionObserver.idl
nsIReflowObserver.idl
nsIRefreshURI.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsIScrollable.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsIScrollObserver.h
nsITooltipListener.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsITooltipTextProvider.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsIURIFixup.idl Bug 1552017 - Expand the kinds of URLs that can cancel content JS when navigating; r=smaug 2019-06-04 16:19:27 +00:00
nsIWebNavigation.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsIWebNavigationInfo.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsIWebPageDescriptor.idl Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan 2019-05-22 22:37:14 +00:00
nsPingListener.cpp Bug 1565767 part 5. Remove some unnecesary refcounting at nsIContent::GetBaseURI callsites. r=peterv 2019-07-15 18:29:05 +00:00
nsPingListener.h
nsRefreshTimer.cpp
nsRefreshTimer.h
nsWebNavigationInfo.cpp
nsWebNavigationInfo.h
SerializedLoadContext.cpp
SerializedLoadContext.h