mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-23 21:01:08 +00:00
d8a12f0303
Previously, TextLeafPoint::GetCaret() returned a placeholder representation of the caret. ActualizeCaret() was then used to get the real caret position, optionally adjusting for the line end depending on the caller's needs. This causes problems when we need to store the TextLeafPoint information in a UIA text range object because the only way to indicate the line end insertion point is to use the GetCaret() placeholder, but that also means the stored position changes if the caret moves. For example, if you disabled NVDA's "caret moves review cursor" setting and then moved the caret, the review cursor should stay at the old position, but it didn't previously. To fix this: 1. TextLeafPoint now has a new mIsEndOfLineInsertionPoint flag which is set to true by GetCaret() if appropriate. 2. GetCaret() sets mAcc and mOffset immediately, rather than needing to call ActualizeCaret() later. 3. TextLeafPoint methods still need to adjust the point to correctly handle the line end insertion point in some cases, but that is now handled by the private TextLeafPoint::AdjustEndOfLine method. 4. FindBoundary now correctly returns the previous character/cluster when requested for this end of line insertion point. Strictly speaking, this bug always existed, but no existing callers ever triggered it. Differential Revision: https://phabricator.services.mozilla.com/D214342 |
||
|---|---|---|
| .. | ||
| AccessibleWrap.cpp | ||
| AccessibleWrap.h | ||
| ApplicationAccessibleWrap.h | ||
| DocAccessibleWrap.cpp | ||
| DocAccessibleWrap.h | ||
| moz.build | ||
| Platform.cpp | ||
| RootAccessibleWrap.h | ||
| SessionAccessibility.cpp | ||
| SessionAccessibility.h | ||
| TraversalRule.cpp | ||
| TraversalRule.h | ||