gecko-dev/dom/media/directshow
Jean-Yves Avenard a8b76dc318 Bug 1256038: Remove special NotifyDataArrived handling in the DirectShow reader. r=cpearce
Following bug 1223599, NotifyDataArrived is called extremely often (every 32kB block downloaded). The combination of pinning the MediaResource with small cache reads while reading on another thread can causes incorrect read.
While this issue needs to be addressed, the special handling of NotifyDataArrived with DirectShow ultimately serves no purpose. By the time we have read the metadata, we have already identified if the MP3 has a known duration. If not, the duration will be amended as data is being returned to the MDSM.

Continually feeding new data to the MP3FrameParser only allow to account for the new data downloaded ahead of the last decoded sample and to get a slightly more accurate buffered range and duration.

The new MP3Demuxer doesn't do it, and ultimately this makes the DirectShowReader behaves like the new MP3Demuxer and gives us consistency across the readers.

MozReview-Commit-ID: HKNWWrofIqV

--HG--
extra : rebase_source : 88d8ef9206e8a16097b2d493681e88b4c174d0c5
2016-03-22 22:59:50 +11:00
..
AudioSinkFilter.cpp Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian 2015-11-15 14:49:01 +01:00
AudioSinkFilter.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
AudioSinkInputPin.cpp Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian 2015-11-15 14:49:01 +01:00
AudioSinkInputPin.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
DirectShowDecoder.cpp Bug 1214989. Part 1 - add MediaDecoderOwner to the constructors of MediaDecoder and sub-classes. r=gerald. 2015-10-15 11:36:21 +08:00
DirectShowDecoder.h Bug 1214989. Part 2 - add MediaDecoderOwner to Clone() and overrides. r=gerald. 2015-10-15 11:37:47 +08:00
DirectShowReader.cpp Bug 1256038: Remove special NotifyDataArrived handling in the DirectShow reader. r=cpearce 2016-03-22 22:59:50 +11:00
DirectShowReader.h Bug 1256038: Remove special NotifyDataArrived handling in the DirectShow reader. r=cpearce 2016-03-22 22:59:50 +11:00
DirectShowUtils.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
DirectShowUtils.h Bug 1208348 - Check whether DirectShow can decode MP3 before assuming it will work. r=jya 2015-09-28 17:57:10 +13:00
moz.build Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium. 2015-08-27 20:44:53 -07:00
SampleSink.cpp Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian 2015-11-15 14:49:01 +01:00
SampleSink.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
SourceFilter.cpp Bug 1219480 - Replace PRLogModuleInfo with LazyLogModule in the media directory. r=rillian 2015-11-15 14:49:01 +01:00
SourceFilter.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00