mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-16 06:45:42 +00:00
27f8f13960
We were seeing almost permaorange failures in the WebRTC H.264/GMP tests
due to the GMP being shutdown in the parent process in between the
content process performing an OOP select operation and then performing
an OOP launch operation.
That is, in GeckoMediaPluginServiceChild::GetContentParent() in between
the SendSelectGMP completing and the SendLaunchGMP completing, the GMP
would shutdown and so when the launch operation ran in the main process
it would fail.
The select and launch are seperate operations so that the crash handler
can be reported to the content process and an association can be made
in the content process between the plugin ID and the crash helper before
we try to launch the GMP. This is so that if the GMP crashes on startup,
we're ready to handle the crash.
However it turns out that if the GMP crashes on startup, the crash report
message comes in after another round of the event/IPC message loop. So we
actually do have time in the content process to connect the crash helper
after the launch fails.
So in order to fix the problem of the GMP shutting down in between select
and launch, we can partially revert the changes I made in Bug 1267918 to
merge selecting and launching GMPs back into a single operation.
MozReview-Commit-ID: 5n4T1Gqlvr3
--HG--
extra : rebase_source : 6e6892a5e32a485b5bfc2f93bddb2d2fe5a422bd
33 lines
918 B
Plaintext
33 lines
918 B
Plaintext
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
include protocol PGMP;
|
|
|
|
using base::ProcessId from "base/process.h";
|
|
|
|
namespace mozilla {
|
|
namespace gmp {
|
|
|
|
sync protocol PGMPService
|
|
{
|
|
parent spawns PGMP as child;
|
|
|
|
parent:
|
|
|
|
sync LaunchGMP(nsCString nodeId,
|
|
nsCString api,
|
|
nsCString[] tags,
|
|
ProcessId[] alreadyBridgedTo)
|
|
returns (uint32_t pluginId, ProcessId id, nsCString displayName, nsresult aResult);
|
|
|
|
sync GetGMPNodeId(nsString origin, nsString topLevelOrigin,
|
|
nsString gmpName,
|
|
bool inPrivateBrowsing)
|
|
returns (nsCString id);
|
|
};
|
|
|
|
} // namespace gmp
|
|
} // namespace mozilla
|