gecko-dev/layout
Emilio Cobos Álvarez d9b9802e71 Bug 1525371 - Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt
Now that there's no ArenaRefPtr, the styles aren't cleared when the shell goes
away (due to an iframe becoming display: none or what not). This caused a few
very confusing failures in test_initial_computation:

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2746a05ce7b20759a820d6f26a55a3200d8e6b8&selectedJob=226267113

Which holds on to a reference of a style on a display: none iframe[1], reframes
it periodically[2], exposing this bug.

For now, keep the id of the shell we got the style from around. When we support
computing styles in display: none iframes this may need more work, but that's
out of the scope of this bug.

[1]: https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/layout/style/test/test_initial_computation.html#56
[2]: https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/layout/style/test/test_initial_computation.html#147

Differential Revision: https://phabricator.services.mozilla.com/D18853
2019-02-07 11:16:12 +01:00
..
base Bug 1525371 - Remove ArenaRefPtr. r=jwatt 2019-02-07 11:15:39 +01:00
build Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2019-01-24 08:11:00 +00:00
doc Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug 2019-01-03 17:48:33 +01:00
forms Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt 2019-02-07 11:15:36 +01:00
generic Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt 2019-02-07 11:15:36 +01:00
inspector Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
ipc Bug 1512990 - Part 4 - remove declarations of Recv/Answer methods from IPDL protocol base class; r=froydnj 2019-02-06 15:58:43 +00:00
mathml Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt 2019-02-07 11:15:36 +01:00
media
painting Bug 1516377 - Use the layout viewport for position:fixed elements if the viewport is larger than. r=botond 2019-02-07 05:39:33 +00:00
printing Bug 1512990 - Part 4 - remove declarations of Recv/Answer methods from IPDL protocol base class; r=froydnj 2019-02-06 15:58:43 +00:00
reftests Bug 1516377 - Use the layout viewport for position:fixed elements if the viewport is larger than. r=botond 2019-02-07 05:39:33 +00:00
style Bug 1525371 - Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt 2019-02-07 11:16:12 +01:00
svg Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt 2019-02-07 11:15:36 +01:00
tables Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt 2019-02-07 11:15:36 +01:00
tools Bug 1522689 - Update command line help for several android test commands; r=bc 2019-02-01 07:18:05 -07:00
xul Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt 2019-02-07 11:15:36 +01:00
moz.build Bug 1521673 - Go through layout/tools/layout-debug even when tests are disabled. r=dmajor 2019-01-22 14:30:39 +00:00