gecko-dev/xpcom/ds/nsPersistentProperties.h
Nika Layzell 7ced96212e Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana
We'll probably want to do something more accurate in the future with a
custom clang static analysis pass which validates that XPIDL interfaces
have the expected vtable and struct layout, however doing so would be
more involved than the string matching done in this patch.

In addition to checking for extra virtual methods, we'll likely also
want to check for data members on interfaces, and reject them unless the
class is marked as `[builtinclass]` in addition to some other attribute
which we'll need to add to prevent them from being implemented in Rust
(as c++ data members will not be reflected by the rust macro).

There were 2 instances of a comment which contained the word 'virtual'
within a CDATA block. These comments were moved out of the CDATA block
to avoid triggering the error.

Differential Revision: https://phabricator.services.mozilla.com/D151068
2022-07-06 14:53:06 +00:00

58 lines
1.4 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef nsPersistentProperties_h___
#define nsPersistentProperties_h___
#include "nsIPersistentProperties2.h"
#include "PLDHashTable.h"
#include "nsString.h"
#include "nsCOMPtr.h"
#include "mozilla/ArenaAllocator.h"
#include "mozilla/Attributes.h"
class nsIUnicharInputStream;
class nsPersistentProperties final : public nsIPersistentProperties {
public:
nsPersistentProperties();
NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIPROPERTIES
NS_DECL_NSIPERSISTENTPROPERTIES
private:
~nsPersistentProperties();
protected:
nsCOMPtr<nsIUnicharInputStream> mIn;
PLDHashTable mTable;
mozilla::ArenaAllocator<2048, 4> mArena;
};
class nsPropertyElement final : public nsIPropertyElement {
public:
nsPropertyElement() = default;
nsPropertyElement(const nsACString& aKey, const nsAString& aValue)
: mKey(aKey), mValue(aValue) {}
NS_DECL_ISUPPORTS
NS_DECL_NSIPROPERTYELEMENT
static nsresult Create(REFNSIID aIID, void** aResult);
private:
~nsPropertyElement() = default;
protected:
nsCString mKey;
nsString mValue;
};
#endif /* nsPersistentProperties_h___ */