Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 16:55:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
dd810760b5
gecko-dev/dom/clients/manager
History
Kris Maglione dd810760b5 Bug 1561015: Part 2 - Return BrowsingContext from openWindow2. r=bzbarsky 
There are some unfortunate aspects of openWindow() and openWindow2() that make
this difficult. Namely, they sometimes return top-level chrome windows, and
sometimes a single content window from the top-level chrome window that they
open, depending on how they're called.

There really isn't any reason to return a BrowsingContext rather than a chrome
window in the former case, but there also really isn't a way to make the API
polymorphic in a way that would allow handling the two cases differently. So
at some point, the two cases should ideally be split into separate APIs rather
than separate special cases of a single API.

In the mean time, I've left openWindow() returning local mozIDOMWindowProxy
objects, since it isn't used by the DOM window.open() or openDialog() APIs,
and only updated openWindow2(). As a follow-up, we should remove both
openWindow() and openWindow2(), and replace them with openChromeWindow() and
openContentWindow() (or similar) methods which make it immediately clear what
type of window is being returned.

Differential Revision: https://phabricator.services.mozilla.com/D35689

--HG--
extra : moz-landing-system : lando
2019-08-02 20:48:40 +00:00
..
ClientChannelHelper.cpp Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku 2019-02-20 13:27:25 +01:00
ClientChannelHelper.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientHandle.cpp Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
ClientHandle.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
ClientHandleChild.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientHandleChild.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientHandleOpChild.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientHandleOpChild.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientHandleOpParent.cpp Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
ClientHandleOpParent.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientHandleParent.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientHandleParent.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientInfo.cpp Bug 965637: Move CSP from Principal into Client, part 1: backend changes. r=mccr8 2019-05-21 23:14:27 +00:00
ClientInfo.h Bug 965637: Move CSP from Principal into Client, part 1: backend changes. r=mccr8 2019-05-21 23:14:27 +00:00
ClientIPCTypes.ipdlh Bug 1554361 - Move the high-level storage access check APIs to mozilla/StorageAccess.h; r=baku 2019-05-27 14:06:49 +00:00
ClientIPCUtils.h Bug 1554361 - Move the high-level storage access check APIs to mozilla/StorageAccess.h; r=baku 2019-05-27 14:06:49 +00:00
ClientManager.cpp Bug 1559919 - Finish the WorkerHolder cleanup - part 7 - IPCWorkerRef in ClientManagerChild, r=asuth 2019-07-12 11:17:46 +00:00
ClientManager.h Bug 1512456 - P6. Tidy up some MozPromise usage. r=gerald 2018-12-11 10:54:48 +00:00
ClientManagerActors.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientManagerActors.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientManagerChild.cpp Bug 1559919 - Finish the WorkerHolder cleanup - part 7 - IPCWorkerRef in ClientManagerChild, r=asuth 2019-07-12 11:17:46 +00:00
ClientManagerChild.h Bug 1559919 - Finish the WorkerHolder cleanup - part 7 - IPCWorkerRef in ClientManagerChild, r=asuth 2019-07-12 11:17:46 +00:00
ClientManagerOpChild.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientManagerOpChild.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientManagerOpParent.cpp Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
ClientManagerOpParent.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientManagerParent.cpp Bug 1517089 - Part 12: Implement ClientManagerService::HasWindow; r=asuth 2019-02-08 21:02:06 +01:00
ClientManagerParent.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientManagerService.cpp Bug 1517089 - Part 12: Implement ClientManagerService::HasWindow; r=asuth 2019-02-08 21:02:06 +01:00
ClientManagerService.h Bug 1517089 - Part 12: Implement ClientManagerService::HasWindow; r=asuth 2019-02-08 21:02:06 +01:00
ClientNavigateOpChild.cpp Bug 1534681 Use ReferrerInfo class in document r=ckerschb,baku,Gijs 2019-06-06 07:23:37 +00:00
ClientNavigateOpChild.h Bug 1512456 - P6. Tidy up some MozPromise usage. r=gerald 2018-12-11 10:54:48 +00:00
ClientNavigateOpParent.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientNavigateOpParent.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientOpenWindowOpActors.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientOpenWindowOpActors.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientOpenWindowOpChild.cpp Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
ClientOpenWindowOpChild.h Bug 1512456 - P6. Tidy up some MozPromise usage. r=gerald 2018-12-11 10:54:48 +00:00
ClientOpenWindowOpParent.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientOpenWindowOpParent.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientOpenWindowUtils.cpp Bug 1561015: Part 2 - Return BrowsingContext from openWindow2. r=bzbarsky 2019-08-02 20:48:40 +00:00
ClientOpenWindowUtils.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
ClientOpPromise.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientPrefs.cpp Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE 2019-07-03 16:08:23 +03:00
ClientPrefs.h Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE 2019-07-03 16:08:23 +03:00
ClientPrincipalUtils.cpp Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
ClientPrincipalUtils.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientSource.cpp Bug 1557244 - Inherit controllers for blob URL workers in child-intercept mode r=asuth 2019-07-26 18:39:58 +00:00
ClientSource.h Bug 965637: Move CSP from Principal into Client, part 1: backend changes. r=mccr8 2019-05-21 23:14:27 +00:00
ClientSourceChild.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientSourceChild.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientSourceOpChild.cpp Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
ClientSourceOpChild.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientSourceOpParent.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientSourceOpParent.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClientSourceParent.cpp Bug 1557244 - Inherit controllers in parent-intercept mode r=asuth 2019-07-26 18:40:05 +00:00
ClientSourceParent.h Bug 1517089 - Part 12: Implement ClientManagerService::HasWindow; r=asuth 2019-02-08 21:02:06 +01:00
ClientState.cpp Bug 1554361 - Move the high-level storage access check APIs to mozilla/StorageAccess.h; r=baku 2019-05-27 14:06:49 +00:00
ClientState.h Bug 1554361 - Move the high-level storage access check APIs to mozilla/StorageAccess.h; r=baku 2019-05-27 14:06:49 +00:00
ClientThing.h Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 2019-04-05 21:41:42 +00:00
ClientValidation.cpp Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE 2019-07-03 16:08:23 +03:00
ClientValidation.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
moz.build Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE 2019-07-03 16:08:23 +03:00
PClientHandle.ipdl
PClientHandleOp.ipdl
PClientManager.ipdl
PClientManagerOp.ipdl
PClientNavigateOp.ipdl
PClientOpenWindowOp.ipdl
PClientSource.ipdl
PClientSourceOp.ipdl