mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-25 03:49:42 +00:00
ea23625d6c
Fortunately, `IMEStateManager::WidgetOnQuit` is called with widget which is not yet destroyed. Therefore, the widget still be able to handle notifications to IME. The problem here is, the widget still have editable input context and there is a native IME handler instance if it's alive during `NOTIFY_IME_OF_FOCUS` and `NOTIFY_IME_OF_BLUR`. `TSFTextStore` which is IME handler in Windows matches this case, and it wants to keep composition even if the application becomes inactive. Therefore, preceding `IMEStateManager::OnChangeFocusInternal` call with `nullptr` for both `aPresContext` and `aElement` cannot notify IME of blur with destroying active `IMEContentObserver` [1] because at the moment, the shutting down process has not started yet. For solving this issue, `IMEStateManager::WidgetOnQuit` directly notifies the widget of `NOTIFY_IME_OF_BLUR` to clean it up the last `TSFTextStore` instance. However, this would cause `NS_ASSERTION` [3] after changing something of `NOTIFY_IME_OF_FOCUS` and `NOTIFY_IME_OF_BLUR`. Therefore, I need to fix this bug for other issues. For solving this, `IMEStateManager::WidgetOnQuit` should destroy active `IMEContentObserver` with normal path to send `NOTIFY_IME_OF_BLUR` and release other unnecessary objects before calling `IMEStateManager::DestroyIMEContentObserver` which clears `sFocusedIMEWidget` and makes active `IMEContentObserver` impossible to send `NOTIFY_IME_OF_BLUR` due to illegal state. 1. https://searchfox.org/mozilla-central/rev/17aeb39742eba71e0936ae44a51a54197100166d/dom/events/IMEStateManager.cpp#549-551 2. https://searchfox.org/mozilla-central/rev/17aeb39742eba71e0936ae44a51a54197100166d/dom/events/IMEStateManager.cpp#242-244 3. https://searchfox.org/mozilla-central/rev/17aeb39742eba71e0936ae44a51a54197100166d/widget/windows/TSFTextStore.cpp#5746 Differential Revision: https://phabricator.services.mozilla.com/D164776