mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-15 03:00:30 +00:00
41c580344f
After some bad experiences, I think EntryReader should be move-only: - It needs to be moveable so it can be created from a function, and move- constructed into a Maybe<> if needed. - It can be passed around as a reference. Previously, it could be passed by value, but it was too easy to create bugs, e.g.: A function delegates to a sub-function to read something at the beginning, then the first function wants to read more past that, but if the reader was passed by value the first function would not see past what the sub-function did read. As a bonus, `mRing` can now be a reference instead of a pointer, and other members can be const. Differential Revision: https://phabricator.services.mozilla.com/D40958 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| android | ||
| baseprofiler | ||
| build | ||
| linker | ||
| misc | ||
| tests | ||
| moz.build | ||