mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-22 09:45:41 +00:00
e0bbb4aa9e
Bug 1256642 introduced magic at the emitter level to determine whether a binary contains C++ sources and should be linked with the C compiler or the C++ compiler. Unfortunately, the Binary() moz.build template always adds C++ OS libraries on Android (through STLPORT_LIBS), and C++ libraries on Linux (stdc++compat). The latter only ends up forcing every Binary() to be linked with the C++ linker, which is unfortunate, but doesn't cause much problems. The former, however, involving OS libraries, the magic from bug 1256642 doesn't kick in, so we end up trying to link C++ OS libraries with the C linker. Which ends up failing, because the libraries in STLPORT_LIBS require -lm, which, while it's added by the C++ compiler when linking, is not when the linkage is driven by the C compiler. Because the fallible library, linked to all GeckoBinary()s is a C++ library, we still ended up linking with the C++ compiler on Android, so this wasn't actually causing any problem... until I tried to remove that fallible library in bug 1423803. Anyways, the core problem is that moz.build evaluation is happening too early to know whether any C++ sources are being linked together, so there is no way the Binary() template can do the right thing. So this change moves the logic to the emitter. This also changes the type of STLPORT_LIBS to a list. --HG-- extra : rebase_source : a70ddf7a132f94dc10e7e1db94ae80fb8d7a269f |
||
|---|---|---|
| .. | ||
| breakpad-client | ||
| breakpad-patches | ||
| breakpad-windows-libxul | ||
| breakpad-windows-standalone | ||
| client | ||
| content | ||
| docs | ||
| google-breakpad | ||
| injector | ||
| minidump-analyzer | ||
| test | ||
| tools | ||
| crashreporter.mozbuild | ||
| CrashReports.jsm | ||
| CrashSubmit.jsm | ||
| InjectCrashReporter.cpp | ||
| InjectCrashReporter.h | ||
| jar.mn | ||
| KeyValueParser.jsm | ||
| LoadLibraryRemote.cpp | ||
| LoadLibraryRemote.h | ||
| mac_utils.h | ||
| mac_utils.mm | ||
| moz.build | ||
| nsDummyExceptionHandler.cpp | ||
| nsExceptionHandler.cpp | ||
| nsExceptionHandler.h | ||
| nsExceptionHandlerUtils.cpp | ||
| nsExceptionHandlerUtils.h | ||
| ThreadAnnotation.cpp | ||
| ThreadAnnotation.h | ||
| update-breakpad.sh | ||
| update-jsoncpp.sh | ||