gecko-dev/dom/svg/SVGPathElement.h
Nathan Froyd 846d8789ee Bug 1492894 - part 1 - make the node hierarchy consistently constructed with NodeInfo&&; r=mccr8
Various places in dom/ use the pattern:

  already_AddRefed<NodeInfo> ni = ...;

which is supposed to be disallowed by our static analysis code, but
isn't, for whatever reason.  To fix our static analysis code, we need to
eliminate instances of the above pattern.

Unfortunately, eliminating this pattern requires restructuring how Nodes
are created.  Most Node subclasses take `already_AddRefed<NodeInfo>&` in
their constructors, and a few accept `already_AddRefed<NodeInfo>&&`.  We
need to enforce the latter pattern consistently, which requires changing
dozens of source files.
2018-09-21 16:45:49 -04:00

113 lines
4.7 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_dom_SVGPathElement_h
#define mozilla_dom_SVGPathElement_h
#include "mozilla/gfx/2D.h"
#include "mozilla/RefPtr.h"
#include "SVGAnimatedPathSegList.h"
#include "SVGGeometryElement.h"
#include "DOMSVGPathSeg.h"
nsresult NS_NewSVGPathElement(nsIContent **aResult,
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo);
namespace mozilla {
class nsISVGPoint;
namespace dom {
typedef SVGGeometryElement SVGPathElementBase;
class SVGPathElement final : public SVGPathElementBase
{
typedef mozilla::gfx::Path Path;
protected:
friend nsresult (::NS_NewSVGPathElement(nsIContent **aResult,
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo));
virtual JSObject* WrapNode(JSContext *cx, JS::Handle<JSObject*> aGivenProto) override;
explicit SVGPathElement(already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo);
public:
NS_DECL_ADDSIZEOFEXCLUDINGTHIS
// nsIContent interface
NS_IMETHOD_(bool) IsAttributeMapped(const nsAtom* name) const override;
// nsSVGSVGElement methods:
virtual bool HasValidDimensions() const override;
// SVGGeometryElement methods:
virtual bool AttributeDefinesGeometry(const nsAtom *aName) override;
virtual bool IsMarkable() override;
virtual void GetMarkPoints(nsTArray<nsSVGMark> *aMarks) override;
virtual already_AddRefed<Path> BuildPath(PathBuilder* aBuilder) override;
/**
* This returns a path without the extra little line segments that
* ApproximateZeroLengthSubpathSquareCaps can insert if we have square-caps.
* See the comment for that function for more info on that.
*/
virtual already_AddRefed<Path> GetOrBuildPathForMeasuring() override;
// nsIContent interface
virtual nsresult Clone(dom::NodeInfo*, nsINode** aResult) const override;
virtual SVGAnimatedPathSegList* GetAnimPathSegList() override {
return &mD;
}
virtual nsAtom* GetPathDataAttrName() const override {
return nsGkAtoms::d;
}
// WebIDL
uint32_t GetPathSegAtLength(float distance);
already_AddRefed<DOMSVGPathSegClosePath> CreateSVGPathSegClosePath();
already_AddRefed<DOMSVGPathSegMovetoAbs> CreateSVGPathSegMovetoAbs(float x, float y);
already_AddRefed<DOMSVGPathSegMovetoRel> CreateSVGPathSegMovetoRel(float x, float y);
already_AddRefed<DOMSVGPathSegLinetoAbs> CreateSVGPathSegLinetoAbs(float x, float y);
already_AddRefed<DOMSVGPathSegLinetoRel> CreateSVGPathSegLinetoRel(float x, float y);
already_AddRefed<DOMSVGPathSegCurvetoCubicAbs>
CreateSVGPathSegCurvetoCubicAbs(float x, float y, float x1, float y1, float x2, float y2);
already_AddRefed<DOMSVGPathSegCurvetoCubicRel>
CreateSVGPathSegCurvetoCubicRel(float x, float y, float x1, float y1, float x2, float y2);
already_AddRefed<DOMSVGPathSegCurvetoQuadraticAbs>
CreateSVGPathSegCurvetoQuadraticAbs(float x, float y, float x1, float y1);
already_AddRefed<DOMSVGPathSegCurvetoQuadraticRel>
CreateSVGPathSegCurvetoQuadraticRel(float x, float y, float x1, float y1);
already_AddRefed<DOMSVGPathSegArcAbs>
CreateSVGPathSegArcAbs(float x, float y, float r1, float r2, float angle, bool largeArcFlag, bool sweepFlag);
already_AddRefed<DOMSVGPathSegArcRel>
CreateSVGPathSegArcRel(float x, float y, float r1, float r2, float angle, bool largeArcFlag, bool sweepFlag);
already_AddRefed<DOMSVGPathSegLinetoHorizontalAbs> CreateSVGPathSegLinetoHorizontalAbs(float x);
already_AddRefed<DOMSVGPathSegLinetoHorizontalRel> CreateSVGPathSegLinetoHorizontalRel(float x);
already_AddRefed<DOMSVGPathSegLinetoVerticalAbs> CreateSVGPathSegLinetoVerticalAbs(float y);
already_AddRefed<DOMSVGPathSegLinetoVerticalRel> CreateSVGPathSegLinetoVerticalRel(float y);
already_AddRefed<DOMSVGPathSegCurvetoCubicSmoothAbs>
CreateSVGPathSegCurvetoCubicSmoothAbs(float x, float y, float x2, float y2);
already_AddRefed<DOMSVGPathSegCurvetoCubicSmoothRel>
CreateSVGPathSegCurvetoCubicSmoothRel(float x, float y, float x2, float y2);
already_AddRefed<DOMSVGPathSegCurvetoQuadraticSmoothAbs>
CreateSVGPathSegCurvetoQuadraticSmoothAbs(float x, float y);
already_AddRefed<DOMSVGPathSegCurvetoQuadraticSmoothRel>
CreateSVGPathSegCurvetoQuadraticSmoothRel(float x, float y);
already_AddRefed<DOMSVGPathSegList> PathSegList();
already_AddRefed<DOMSVGPathSegList> AnimatedPathSegList();
protected:
SVGAnimatedPathSegList mD;
};
} // namespace dom
} // namespace mozilla
#endif // mozilla_dom_SVGPathElement_h