gecko-dev/dom/svg/SVGStyleElement.cpp
Nathan Froyd 846d8789ee Bug 1492894 - part 1 - make the node hierarchy consistently constructed with NodeInfo&&; r=mccr8
Various places in dom/ use the pattern:

  already_AddRefed<NodeInfo> ni = ...;

which is supposed to be disallowed by our static analysis code, but
isn't, for whatever reason.  To fix our static analysis code, we need to
eliminate instances of the above pattern.

Unfortunately, eliminating this pattern requires restructuring how Nodes
are created.  Most Node subclasses take `already_AddRefed<NodeInfo>&` in
their constructors, and a few accept `already_AddRefed<NodeInfo>&&`.  We
need to enforce the latter pattern consistently, which requires changing
dozens of source files.
2018-09-21 16:45:49 -04:00

249 lines
6.7 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/dom/Element.h"
#include "mozilla/dom/SVGStyleElement.h"
#include "nsContentUtils.h"
#include "mozilla/dom/SVGStyleElementBinding.h"
NS_IMPL_NS_NEW_NAMESPACED_SVG_ELEMENT(Style)
namespace mozilla {
namespace dom {
JSObject*
SVGStyleElement::WrapNode(JSContext *aCx, JS::Handle<JSObject*> aGivenProto)
{
return SVGStyleElement_Binding::Wrap(aCx, this, aGivenProto);
}
//----------------------------------------------------------------------
// nsISupports methods
NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED(SVGStyleElement,
SVGStyleElementBase,
nsIStyleSheetLinkingElement,
nsIMutationObserver)
NS_IMPL_CYCLE_COLLECTION_CLASS(SVGStyleElement)
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(SVGStyleElement,
SVGStyleElementBase)
tmp->nsStyleLinkElement::Traverse(cb);
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(SVGStyleElement,
SVGStyleElementBase)
tmp->nsStyleLinkElement::Unlink();
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
//----------------------------------------------------------------------
// Implementation
SVGStyleElement::SVGStyleElement(already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo)
: SVGStyleElementBase(std::move(aNodeInfo))
{
AddMutationObserver(this);
}
SVGStyleElement::~SVGStyleElement()
{
}
//----------------------------------------------------------------------
// nsINode methods
NS_IMPL_ELEMENT_CLONE_WITH_INIT(SVGStyleElement)
//----------------------------------------------------------------------
// nsIContent methods
nsresult
SVGStyleElement::BindToTree(nsIDocument* aDocument, nsIContent* aParent,
nsIContent* aBindingParent)
{
nsresult rv = SVGStyleElementBase::BindToTree(aDocument, aParent,
aBindingParent);
NS_ENSURE_SUCCESS(rv, rv);
void (SVGStyleElement::*update)() = &SVGStyleElement::UpdateStyleSheetInternal;
nsContentUtils::AddScriptRunner(
NewRunnableMethod("dom::SVGStyleElement::BindToTree", this, update));
return rv;
}
void
SVGStyleElement::UnbindFromTree(bool aDeep, bool aNullParent)
{
nsCOMPtr<nsIDocument> oldDoc = GetUncomposedDoc();
ShadowRoot* oldShadow = GetContainingShadow();
SVGStyleElementBase::UnbindFromTree(aDeep, aNullParent);
Unused << UpdateStyleSheetInternal(oldDoc, oldShadow);
}
nsresult
SVGStyleElement::AfterSetAttr(int32_t aNameSpaceID, nsAtom* aName,
const nsAttrValue* aValue,
const nsAttrValue* aOldValue,
nsIPrincipal* aMaybeScriptedPrincipal,
bool aNotify)
{
if (aNameSpaceID == kNameSpaceID_None) {
if (aName == nsGkAtoms::title ||
aName == nsGkAtoms::media ||
aName == nsGkAtoms::type) {
Unused << UpdateStyleSheetInternal(nullptr, nullptr, ForceUpdate::Yes);
}
}
return SVGStyleElementBase::AfterSetAttr(aNameSpaceID, aName, aValue,
aOldValue, aMaybeScriptedPrincipal,
aNotify);
}
bool
SVGStyleElement::ParseAttribute(int32_t aNamespaceID,
nsAtom* aAttribute,
const nsAString& aValue,
nsIPrincipal* aMaybeScriptedPrincipal,
nsAttrValue& aResult)
{
if (aNamespaceID == kNameSpaceID_None &&
aAttribute == nsGkAtoms::crossorigin) {
ParseCORSValue(aValue, aResult);
return true;
}
return SVGStyleElementBase::ParseAttribute(aNamespaceID, aAttribute, aValue,
aMaybeScriptedPrincipal, aResult);
}
//----------------------------------------------------------------------
// nsIMutationObserver methods
void
SVGStyleElement::CharacterDataChanged(nsIContent* aContent,
const CharacterDataChangeInfo&)
{
ContentChanged(aContent);
}
void
SVGStyleElement::ContentAppended(nsIContent* aFirstNewContent)
{
ContentChanged(aFirstNewContent->GetParent());
}
void
SVGStyleElement::ContentInserted(nsIContent* aChild)
{
ContentChanged(aChild);
}
void
SVGStyleElement::ContentRemoved(nsIContent* aChild,
nsIContent* aPreviousSibling)
{
ContentChanged(aChild);
}
void
SVGStyleElement::ContentChanged(nsIContent* aContent)
{
if (nsContentUtils::IsInSameAnonymousTree(this, aContent)) {
Unused << UpdateStyleSheetInternal(nullptr, nullptr);
}
}
//----------------------------------------------------------------------
void
SVGStyleElement::GetXmlspace(nsAString & aXmlspace)
{
GetAttr(kNameSpaceID_XML, nsGkAtoms::space, aXmlspace);
}
void
SVGStyleElement::SetXmlspace(const nsAString & aXmlspace, ErrorResult& rv)
{
rv = SetAttr(kNameSpaceID_XML, nsGkAtoms::space, aXmlspace, true);
}
void
SVGStyleElement::GetMedia(nsAString & aMedia)
{
GetAttr(nsGkAtoms::media, aMedia);
}
void
SVGStyleElement::SetMedia(const nsAString& aMedia, ErrorResult& rv)
{
SetAttr(nsGkAtoms::media, aMedia, rv);
}
void
SVGStyleElement::GetType(nsAString & aType)
{
GetAttr(nsGkAtoms::type, aType);
}
void
SVGStyleElement::SetType(const nsAString& aType, ErrorResult& rv)
{
SetAttr(nsGkAtoms::type, aType, rv);
}
void
SVGStyleElement::GetTitle(nsAString & aTitle)
{
GetAttr(nsGkAtoms::title, aTitle);
}
void
SVGStyleElement::SetTitle(const nsAString& aTitle, ErrorResult& rv)
{
SetAttr(nsGkAtoms::title, aTitle, rv);
}
//----------------------------------------------------------------------
// nsStyleLinkElement methods
Maybe<nsStyleLinkElement::SheetInfo>
SVGStyleElement::GetStyleSheetInfo()
{
if (!IsCSSMimeTypeAttribute(*this)) {
return Nothing();
}
nsAutoString title;
nsAutoString media;
GetTitleAndMediaForElement(*this, title, media);
return Some(SheetInfo {
*OwnerDoc(),
this,
nullptr,
// FIXME(bug 1459822): Why doesn't this need a principal, but
// HTMLStyleElement does?
nullptr,
net::ReferrerPolicy::RP_Unset,
// FIXME(bug 1459822): Why does this need a crossorigin attribute, but
// HTMLStyleElement doesn't?
AttrValueToCORSMode(GetParsedAttr(nsGkAtoms::crossorigin)),
title,
media,
HasAlternateRel::No,
IsInline::Yes,
});
}
} // namespace dom
} // namespace mozilla