gecko-dev/browser/modules/Discovery.jsm
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00

120 lines
4.3 KiB
JavaScript

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
var EXPORTED_SYMBOLS = [
"Discovery",
];
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
ChromeUtils.defineModuleGetter(this, "ClientID",
"resource://gre/modules/ClientID.jsm");
ChromeUtils.defineModuleGetter(this, "ContextualIdentityService",
"resource://gre/modules/ContextualIdentityService.jsm");
const RECOMMENDATION_ENABLED = "browser.discovery.enabled";
const TELEMETRY_ENABLED = "datareporting.healthreport.uploadEnabled";
const TAAR_COOKIE_NAME = "taarId";
const Discovery = {
set enabled(val) {
val = !!val;
if (val && !gTelemetryEnabled) {
throw Error("unable to turn on recommendations");
}
Services.prefs.setBoolPref(RECOMMENDATION_ENABLED, val);
},
get enabled() {
return gTelemetryEnabled && gRecommendationEnabled;
},
reset() {
return DiscoveryInternal.update(true);
},
update() {
return DiscoveryInternal.update();
},
};
XPCOMUtils.defineLazyPreferenceGetter(this, "gRecommendationEnabled",
RECOMMENDATION_ENABLED, false,
Discovery.update);
XPCOMUtils.defineLazyPreferenceGetter(this, "gTelemetryEnabled",
TELEMETRY_ENABLED, false,
Discovery.update);
XPCOMUtils.defineLazyPreferenceGetter(this, "gCachedClientID",
"toolkit.telemetry.cachedClientID", "",
Discovery.reset);
XPCOMUtils.defineLazyPreferenceGetter(this, "gContainersEnabled",
"browser.discovery.containers.enabled", false,
Discovery.reset);
Services.obs.addObserver(Discovery.update, "contextual-identity-created");
const DiscoveryInternal = {
get sites() {
delete this.sites;
this.sites = Services.prefs.getCharPref("browser.discovery.sites", "").split(",");
return this.sites;
},
getContextualIDs() {
// There is never a zero id, this is just for use in update.
let IDs = [0];
if (gContainersEnabled) {
ContextualIdentityService.getPublicIdentities().forEach(identity => {
IDs.push(identity.userContextId);
});
}
return IDs;
},
async update(reset = false) {
if (reset || !Discovery.enabled) {
for (let site of this.sites) {
Services.cookies.remove(site, TAAR_COOKIE_NAME, "/", false, {});
ContextualIdentityService.getPublicIdentities().forEach(identity => {
let {userContextId} = identity;
Services.cookies.remove(site, TAAR_COOKIE_NAME, "/", false, {userContextId});
});
}
}
if (Discovery.enabled) {
// If the client id is not cached, wait for the notification that it is
// cached. This will happen shortly after startup in TelemetryController.jsm.
// When that happens, we'll get a pref notification for the cached id,
// which will call update again.
if (!gCachedClientID) {
return;
}
let id = await ClientID.getClientIdHash();
for (let site of this.sites) {
// This cookie gets tied down as much as possible. Specifically,
// SameSite, Secure, HttpOnly and non-PrivateBrowsing.
for (let userContextId of this.getContextualIDs()) {
let originAttributes = {privateBrowsingId: 0};
if (userContextId > 0) {
originAttributes.userContextId = userContextId;
}
if (Services.cookies.cookieExists(site, "/", TAAR_COOKIE_NAME, originAttributes)) {
continue;
}
Services.cookies.add(site, "/", TAAR_COOKIE_NAME, id,
true, // secure
true, // httpOnly
true, // session
Date.now(),
originAttributes,
Ci.nsICookie2.SAMESITE_LAX);
}
}
}
},
};