nboyd%atg.com e737c6d867 Subject: ... Re: Small usage simplification for Rhino Date: Mon, 22 Jan 2001 20:32:12 +0100 From: Igor Bukanov <igor@icesoft.no> To: Norris Boyd <nboyd@atg.com> References: 1 , 2 Norris Boyd wrote: > Sounds like a good change to reduce codesize. I'll take the patches for the > changes. > > Thanks, > Norris I made this patch, the files in the attachment were produced via: diff -bB javascript.orig javascript -c > patch_context and diff -bB javascript.orig javascript > patch_std run from org/mozilla directory. This patch reduces uncopressed Rhino jar by 3K. > > Igor Bukanov wrote: > > >> Hi, Noris! >> >> To shorten/cleanup usage of getMessage and reportRuntimeError methods >> from org/mozilla/javascript/Context.java I suggest to add few utility >> methods like >> >> static String getMessage0(String messageId) { >> return getMessage(messageId, null); >> } >> >> static String getMessage1(String messageId, Object arg1) { >> Object[] arguments = {arg1}; >> return getMessage(messageId, arguments); >> } >> >> static String getMessage2(String messageId, Object arg1, Object arg2) { >> Object[] arguments = {arg1, arg2}; >> return getMessage(messageId, arguments); >> } >> >> static String getMessage3 >> (String messageId, Object arg1, Object arg2, Object arg3) { >> Object[] arguments = {arg1, arg2, arg3}; >> return getMessage(messageId, arguments); >> } >> >> and >> >> static EvaluatorException reportRuntimeError0(String messageId) { >> return reportRuntimeError(getMessage0(messageId)); >> } >> >> static EvaluatorException reportRuntimeError1 >> (String messageId, Object arg1) >> { >> return reportRuntimeError(getMessage1(messageId, arg1)); >> } >> >> static EvaluatorException reportRuntimeError2 >> (String messageId, Object arg1, Object arg2) >> { >> return reportRuntimeError(getMessage2(messageId, arg1, arg2)); >> } >> >> static EvaluatorException reportRuntimeError3 >> (String messageId, Object arg1, Object arg2, Object arg3) >> { >> return reportRuntimeError(getMessage3(messageId, arg1, arg2, >> arg3)); >> } >> >> This allows to write, for example, instead of >> >> Object[] args = { Integer.toString(base) }; >> throw Context.reportRuntimeError(getMessage >> ("msg.bad.radix", args)); >> simply >> throw Context.reportRuntimeError1( >> "msg.bad.radix", Integer.toString(base)); >> >> which is not only easy to read but also generates less code. >> >> I attach my patch to Context.java to implement this plus a patch to >> ScriptRuntime.java that utilizes the additions. The patches are in >> standard and context versions. >> >> If you think that this make sense to incorporate, I can send a patch >> that utilizes this everywhere. >> >> ------------------------------------------------------------------------ >> Name: patch.context.Context.java >> patch.context.Context.java Type: Plain Text (text/plain) >> Encoding: base64 >> >> Name: patch.std.Context.java >> patch.std.Context.java Type: Plain Text (text/plain) >> Encoding: base64 >> >> Name: patch.context.ScriptRuntime.java >> patch.context.ScriptRuntime.java Type: Plain Text (text/plain) >> Encoding: base64 >> >> Name: patch.std.ScriptRuntime.java >> patch.std.ScriptRuntime.java Type: Plain Text (text/plain) >> Encoding: base64 >> >> Name: all.zip >> all.zip Type: Zip Compressed Data (application/x-zip-compressed) >> Encoding: base64		2001-01-22 20:28:34 +00:00
..
benchmarks	Add benchmarks.	1999-06-04 18:44:17 +00:00
js2	Added <function> at top level and example thereof.	2001-01-20 00:44:51 +00:00
jsd	NOT PART OF SEAMONKEY BUILD - removed misplaced semi-colon added by toshok on 6 Sep 1999 which had converted a conditional block into a non-conditional block and made the debugger completely non functional	2000-02-19 02:34:05 +00:00
jsdj	updated license boilerplate to xPL 1.1, a=chofmann@netscape.com,r=endico@mozilla.org	1999-11-06 02:47:15 +00:00
jsj
macbuild	Removing dead .toc files. Not part of build. a=sfraser.	2001-01-03 01:32:06 +00:00
ref
rhino	Subject:	2001-01-22 20:28:34 +00:00
semantics	Separated statements into statements, diretives, and definitions	2001-01-12 07:33:19 +00:00
src	Followup to last checkin, comment change only, r=mccabe.	2001-01-20 02:02:48 +00:00
tests	Correcting bug that cropped up when system clock was set to GMT Standard Time	2001-01-01 02:40:28 +00:00
.cvsignore	more anal tricks.	1999-06-26 05:01:40 +00:00
landbranch.pl
Makefile.in	updated license boilerplate to xPL 1.1, a=chofmann@netscape.com,r=endico@mozilla.org	1999-11-06 03:40:37 +00:00
makefile.win	updated license boilerplate to xPL 1.1, a=chofmann@netscape.com,r=endico@mozilla.org	1999-11-06 03:40:37 +00:00