gecko-dev/servo
Emilio Cobos Álvarez e80b8667d5 Bug 1469076: Fix the broken invariants of the rule node cache. r=heycam
We were spuriously reframing the <shadow> because it initially shared style with
the <br>, which ended up being display: none, while the <shadow> should've been
display: contents from the beginning.

lookup_by_rules seems pretty prone to obscure bugs, and also it's pretty
complex... Probably we should try to get rid of it, I'm unconvinced that it's
worth it.

Even with that, in a normal restyle the <details> wouldn't have ended up with a
style. It of course never had it before the reframe because the <shadow> was
display: none, but that doesn't mean it shouldn't have gotten one, since we
detected we needed to go through kids in:

  https://searchfox.org/mozilla-central/rev/6eea08365e7386a2b81c044e7cc8a3daa51d8754/servo/components/style/matching.rs#500

That code did happen, but since it's an animation-only restyle, we don't look at
unstyled stuff.

That looks somewhat fishy, but I guess for now it's fine as long as display
isn't animatable.

MozReview-Commit-ID: B6NMSTNOKgK
2018-06-20 11:21:35 +02:00
..
components Bug 1469076: Fix the broken invariants of the rule node cache. r=heycam 2018-06-20 11:21:35 +02:00
ports/geckolib Bug 1468665: Don't call the before change closure with the locked declaration block. r=xidorn 2018-06-19 12:58:29 +02:00
support/gecko/nsstring Bug 1464834: Remove dead servo code. r=xidorn,heycam 2018-05-29 10:28:11 +02:00
tests/unit Bug 1464834: Remove dead servo code. r=xidorn,heycam 2018-05-29 10:28:11 +02:00
moz.build Bug 1464834: Bring back servo/moz.build to fix the linting failure. r=me 2018-05-29 11:07:31 +02:00