gecko-dev/build
Chris Peterson eb00c7365e Bug 1807583 - Enable -Wtautological-constant-in-range-compare warnings. r=firefox-build-system-reviewers,glandium
There are no -Wtautological-constant-in-range-compare warnings in C or C++ code in mozilla-central, so we can enable this warning.

However, the -Wtautological-constant-in-range-compare flag also enables -Wtautological-value-range-compare warnings and there are some -Wtautological-value-range-compare warnings in some third-party C code.

I filed https://bugs.chromium.org/p/google-breakpad/issues/detail?id=859 for the Google Breakpad warning.

---

toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/ia32_invariant.c:112:30 [-Wtautological-value-range-compare] result of comparison of 3-bit unsigned value == 101 is always false

js/src/zydis/Zydis/Decoder.c:2200:43 [-Wtautological-value-range-compare] result of comparison of 2-bit unsigned value < 4 is always true
js/src/zydis/Zydis/Decoder.c:2213:43 [-Wtautological-value-range-compare] result of comparison of 2-bit unsigned value < 4 is always true
js/src/zydis/Zydis/Decoder.c:2226:43 [-Wtautological-value-range-compare] result of comparison of 2-bit unsigned value < 4 is always true
js/src/zydis/Zydis/Decoder.c:3650:46 [-Wtautological-value-range-compare] result of comparison of 3-bit unsigned value < 8 is always true
js/src/zydis/Zydis/SharedData.c:119:47 [-Wtautological-value-range-compare] result of comparison of 15-bit unsigned value != 65535 is always true

third_party/aom/aom_dsp/intrapred.c:94:3 [-Wtautological-value-range-compare] result of comparison of 4-bit unsigned value < 31 is always true
third_party/aom/aom_dsp/intrapred.c:123:3 [-Wtautological-value-range-compare] result of comparison of 4-bit unsigned value < 31 is always true
third_party/aom/aom_dsp/intrapred.c:152:3 [-Wtautological-value-range-compare] result of comparison of 4-bit unsigned value < 31 is always true
third_party/aom/aom_dsp/intrapred.c:413:3 [-Wtautological-value-range-compare] result of comparison of 4-bit unsigned value < 31 is always true
third_party/aom/aom_dsp/intrapred.c:444:3 [-Wtautological-value-range-compare] result of comparison of 4-bit unsigned value < 31 is always true
third_party/aom/aom_dsp/intrapred.c:475:3 [-Wtautological-value-range-compare] result of comparison of 4-bit unsigned value < 31 is always true

Differential Revision: https://phabricator.services.mozilla.com/D165522
2023-01-20 04:53:27 +00:00
..
autoconf Bug 1795207 - Move the remainder of warning flags setup in old-configure to python. r=firefox-build-system-reviewers,andi 2022-10-18 19:46:44 +00:00
build-clang Bug 1809769 - Refresh patches against last changes in clang trunk. r=firefox-build-system-reviewers,ahochheiden 2023-01-12 03:00:06 +00:00
build-rust Bug 1797419 - Update builders to rustc 1.66. r=firefox-build-system-reviewers,ahochheiden 2022-12-19 22:14:46 +00:00
clang-plugin Bug 1806040 - Preserve host ldflags from configure when building clang-plugin. r=firefox-build-system-reviewers,ahochheiden 2022-12-28 21:01:59 +00:00
compare-mozconfig Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 2022-12-23 22:45:46 +00:00
debian-packages Bug 1789954 - Upgrade valgrind to 3.19.0. r=firefox-build-system-reviewers,ahochheiden 2022-09-13 21:43:23 +00:00
docs Bug 1799470 - Refactor app starter r=nika 2023-01-18 15:46:09 +00:00
gyp_includes
macosx Bug 1773741 - Switch builds to the macOS 13 SDK. r=firefox-build-system-reviewers,spohl,andi 2023-01-19 01:40:37 +00:00
moz.configure Bug 1807583 - Enable -Wtautological-constant-in-range-compare warnings. r=firefox-build-system-reviewers,glandium 2023-01-20 04:53:27 +00:00
package/mac_osx
pgo Bug 1790816 - Reformat build/ with isort. r=linter-reviewers,ahal DONTBUILD 2022-11-24 17:23:47 +00:00
rust Bug 1793784 - Replace the minidump_writer_linux crate with the minidump-writer crate r=glandium,supply-chain-reviewers 2023-01-10 22:14:30 +00:00
sanitizers Bug 1801932 - Remove suppressions function UBSan check. r=firefox-build-system-reviewers,ahochheiden 2022-11-25 17:29:56 +00:00
sparse-profiles Bug 1807780 - Remove now unused liblowercase. r=firefox-build-system-reviewers,ahochheiden 2022-12-29 00:05:49 +00:00
tests/cram
unix Bug 1806761 - Use toolchain binutils in base-toolchain builds. r=firefox-build-system-reviewers,nalexander 2022-12-28 21:07:04 +00:00
valgrind Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 2022-12-23 22:45:46 +00:00
vs Bug 1807780 - Use -ivfsoverlay instead of liblowercase. r=firefox-build-system-reviewers,ahochheiden 2022-12-29 00:05:49 +00:00
win32 Bug 1807780 - Use -ivfsoverlay instead of liblowercase. r=firefox-build-system-reviewers,ahochheiden 2022-12-29 00:05:49 +00:00
win64 Bug 1807780 - Use -ivfsoverlay instead of liblowercase. r=firefox-build-system-reviewers,ahochheiden 2022-12-29 00:05:49 +00:00
win64-aarch64 Bug 1807780 - Fix win aarch64 build bustage. CLOSED TREE 2022-12-29 04:02:26 +02:00
workspace-hack Bug 1802689 - Add missing licenses info in Cargo.toml r=mhoye,necko-reviewers,kershaw,valentin 2022-12-13 09:14:44 +00:00
__init__.py
.gdbinit
.gdbinit.loader
.gdbinit.py.in
.lldbinit.in
appini_header.py Bug 1797894 - Set gAppData->vendor to NULL when not set otherwise. r=glandium 2022-11-01 23:51:51 +00:00
application.ini.in
binary-location.mk
buildconfig.py Bug 1790816 - Reformat build/ with isort. r=linter-reviewers,ahal DONTBUILD 2022-11-24 17:23:47 +00:00
cargo-host-linker
cargo-host-linker.bat
cargo-linker Bug 1790816 - Reformat build/ with isort. r=linter-reviewers,ahal DONTBUILD 2022-11-24 17:23:47 +00:00
cargo-linker.bat Bug 1800462 - Revert the Windows part of bug 1791476. r=firefox-build-system-reviewers,andi 2022-11-16 05:35:20 +00:00
checksums.py Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 2022-12-23 22:45:46 +00:00
defines.sh
dumbmake-dependencies
gecko_templates.mozbuild
gen_symverscript.py Bug 1790816 - Reformat build/ with isort. r=linter-reviewers,ahal DONTBUILD 2022-11-24 17:23:47 +00:00
gen_test_packages_manifest.py Bug 1790816 - Reformat build/ with isort. r=linter-reviewers,ahal DONTBUILD 2022-11-24 17:23:47 +00:00
gyp_base.mozbuild
gyp.mozbuild
mach_initialize.py Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 2022-12-23 22:45:46 +00:00
midl.py Bug 1807780 - Use -ivfsoverlay instead of liblowercase. r=firefox-build-system-reviewers,ahochheiden 2022-12-29 00:05:49 +00:00
moz-automation.mk
moz.build
mozconfig.artifact
mozconfig.artifact.automation
mozconfig.automation
mozconfig.cache Bug 1805699 - Use a prefix on GCP sccache bucket names. r=firefox-build-system-reviewers,ahochheiden 2023-01-17 13:29:43 +00:00
mozconfig.clang-cl
mozconfig.comm-support
mozconfig.common Bug 1770251 - Centralize PGO mozconfig bits. r=firefox-build-system-reviewers,andi 2022-05-20 08:31:46 +00:00
mozconfig.common.override
mozconfig.lld-link
mozconfig.no-compile Bug 1807779 - Allow to set a single variable for MSVC. r=firefox-build-system-reviewers,ahochheiden 2022-12-28 22:48:51 +00:00
mozconfig.rust
mozconfig.win-common Bug 1770251 - Centralize PGO mozconfig bits. r=firefox-build-system-reviewers,andi 2022-05-20 08:31:46 +00:00
non-unified-compat
psutil_requirements.in Bug 1801726 - Upgrade psutil to 5.9.4. r=firefox-build-system-reviewers,ahochheiden 2022-11-22 09:12:02 +00:00
psutil_requirements.txt Bug 1801726 - Upgrade psutil to 5.9.4. r=firefox-build-system-reviewers,ahochheiden 2022-11-22 09:12:02 +00:00
qemu-wrap
RunCbindgen.py Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 2022-12-23 22:45:46 +00:00
templates.mozbuild Bug 1795215 - Keep -Wno-* flags when disabling compiler warnings. r=firefox-build-system-reviewers,andi 2022-10-18 19:46:45 +00:00
update-settings.ini
upload_generated_sources.py Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 2022-12-23 22:45:46 +00:00
upload.py Bug 1790816 - Reformat build/ with isort. r=linter-reviewers,ahal DONTBUILD 2022-11-24 17:23:47 +00:00
variables.py Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 2022-12-23 22:45:46 +00:00
zstandard_requirements.in Bug 1801726 - Upgrade zstandard to 0.19.0. r=firefox-build-system-reviewers,ahochheiden 2022-11-22 09:12:02 +00:00
zstandard_requirements.txt Bug 1801726 - Upgrade zstandard to 0.19.0. r=firefox-build-system-reviewers,ahochheiden 2022-11-22 09:12:02 +00:00