Patrick McManus 175115e709 bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz ... These scriptable interfaces use uint_64 arguments with sentinel values of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot be gatewayed to/from javascript - so they cannot be used correctly. Change them to use signed 64 bit numbers and -1 as the sentinnel. C++ implementations ought to be enough to audit as the special value could never be used correctly in JS anyhow - also audited OnProgressChange() uses for downstream use of this data. --- dom/base/nsXMLHttpRequest.cpp | 19 +++++++---- dom/base/nsXMLHttpRequest.h | 10 +++--- dom/plugins/base/nsPluginStreamListenerPeer.cpp | 4 +-- .../webbrowserpersist/nsWebBrowserPersist.cpp | 14 ++++---- image/src/imgLoader.cpp | 4 +-- modules/libjar/nsJARChannel.cpp | 3 +- netwerk/base/public/nsIProgressEventSink.idl | 8 ++--- netwerk/base/public/nsITransport.idl | 8 ++--- netwerk/base/public/nsNetUtil.h | 24 ++++++++++++++ netwerk/base/src/Dashboard.cpp | 2 +- netwerk/base/src/nsBaseChannel.cpp | 12 +++---- netwerk/base/src/nsIncrementalDownload.cpp | 4 +-- netwerk/base/src/nsSocketTransport2.cpp | 5 +-- netwerk/base/src/nsStreamTransportService.cpp | 38 +++++++++++++--------- netwerk/base/src/nsTransportUtils.cpp | 12 +++---- netwerk/protocol/file/nsFileChannel.cpp | 8 +++-- netwerk/protocol/ftp/nsFtpConnectionThread.cpp | 4 +-- netwerk/protocol/http/Http2Push.cpp | 2 +- netwerk/protocol/http/Http2Session.cpp | 2 +- netwerk/protocol/http/HttpChannelChild.cpp | 31 +++++++++--------- netwerk/protocol/http/HttpChannelChild.h | 6 ++-- netwerk/protocol/http/HttpChannelParent.cpp | 4 +-- netwerk/protocol/http/HttpChannelParent.h | 4 +-- netwerk/protocol/http/NullHttpTransaction.cpp | 2 +- netwerk/protocol/http/PHttpChannel.ipdl | 2 +- netwerk/protocol/http/SpdyPush31.cpp | 2 +- netwerk/protocol/http/SpdySession31.cpp | 2 +- netwerk/protocol/http/TunnelUtils.cpp | 2 +- netwerk/protocol/http/nsAHttpTransaction.h | 4 +-- netwerk/protocol/http/nsHttpChannel.cpp | 30 +++++++++++------ netwerk/protocol/http/nsHttpConnection.cpp | 4 +-- netwerk/protocol/http/nsHttpConnectionMgr.cpp | 4 +-- netwerk/protocol/http/nsHttpPipeline.cpp | 4 +-- netwerk/protocol/http/nsHttpPipeline.h | 6 ++-- netwerk/protocol/http/nsHttpResponseHead.cpp | 2 +- netwerk/protocol/http/nsHttpResponseHead.h | 2 +- netwerk/protocol/http/nsHttpTransaction.cpp | 32 +++++++++--------- netwerk/protocol/http/nsHttpTransaction.h | 2 +- netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp | 2 +- netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp | 3 +- netwerk/test/TestIncrementalDownload.cpp | 7 ++-- uriloader/base/nsDocLoader.cpp | 14 ++++---- 42 files changed, 203 insertions(+), 151 deletions(-)		2015-01-08 14:48:52 -05:00
..
test	Bug 1087738: Make JS callers of ios.newChannel call ios.newChannel2 in modules/ (r=mwu)	2014-10-24 15:06:16 -07:00
zipwriter	Bug 1087738: Make JS callers of ios.newChannel call ios.newChannel2 in modules/ (r=mwu)	2014-10-24 15:06:16 -07:00
appnote.txt
moz.build	Bug 1043802 - Remove TOOLS_DIRS and TEST_TOOLS_DIRS. r=gps	2014-07-29 08:55:55 +09:00
nsIJARChannel.idl	Bug 1048579 - Update the nsIChannel UUID. rs=Ms2ger	2014-08-25 09:55:57 -04:00
nsIJARFactory.h
nsIJARProtocolHandler.idl
nsIJARURI.idl
nsIZipReader.idl	Bug 1050518 - Remove nsICertificatePrincipal. r=keeler	2014-09-10 20:31:00 -04:00
nsJAR.cpp	Bug 1050518 - Remove nsICertificatePrincipal. r=keeler	2014-09-10 20:31:00 -04:00
nsJAR.h	Bug 1050518 - Remove nsICertificatePrincipal. r=keeler	2014-09-10 20:31:00 -04:00
nsJARChannel.cpp	bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz	2015-01-08 14:48:52 -05:00
nsJARChannel.h	Bug 1059832 - Disallow initiating asynchronous remote JAR channel requests for synchronous operations. r=jduell	2014-09-15 13:00:08 -04:00
nsJARFactory.cpp	Bug 951511. If jar module shutdown happens before all the jar channels are destroyed, we still shouldn't crash. r=bsmedberg	2013-12-18 11:20:45 -05:00
nsJARInputStream.cpp	Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj	2014-04-27 03:06:00 -04:00
nsJARInputStream.h	Bug 1028588 - Fix dangerous public destructors in libjar/ - r=aklotz	2014-06-24 22:09:14 -04:00
nsJARProtocolHandler.cpp	Bug 1087442 - Attach LoadInfo inside each individual ProtocolHandler - modules/ changes (r=mwu)	2014-12-12 09:07:23 -08:00
nsJARProtocolHandler.h	bug 1105074 - make more stuff final r=froydnj	2014-11-25 13:56:07 -05:00
nsJARURI.cpp	Bug 345123: Remove nsGetterAddRefs<T>'s operator nsISupports**. r=bsmedberg	2014-03-15 12:00:17 -07:00
nsJARURI.h	bug 1059490 - mark more classes MOZ_FINAL r=froydnj	2014-08-27 14:26:48 -04:00
nsZipArchive.cpp	Bug 988816 - Allow to keep file descriptor in JAR cache. r=aklotz, jduell	2014-07-18 10:46:24 +08:00
nsZipArchive.h	Bug 1118486 - Part 1: Use = delete instead of MOZ_DELETE directly; r=Waldo	2015-01-08 23:19:05 -05:00
zipstruct.h