gecko-dev/netwerk/base/NetworkConnectivityService.h
Valentin Gosu 50fee6b27e Bug 1556911 - Don't instantiate NetworkConnectivityService off-main-thread r=dragana
This patch calls NetworkConnectivityService::GetSingleton() on the main thread
and keeps a ref to the service until shutdown.
Even though calling ncs->GetIPv6() off-main-thread is technically a data-race
in practice that's OK because only the simple decision whether to send
AAAA requests is made based on that value, which in itself is an optimization.
I filed bug 1556967 for making the connectivity service thread safe.

Differential Revision: https://phabricator.services.mozilla.com/D33765

--HG--
extra : moz-landing-system : lando
2019-06-05 20:39:12 +00:00

58 lines
1.8 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef NetworkConnectivityService_h_
#define NetworkConnectivityService_h_
#include "nsINetworkConnectivityService.h"
#include "nsIObserver.h"
#include "nsIDNSListener.h"
#include "nsIStreamListener.h"
namespace mozilla {
namespace net {
class NetworkConnectivityService : public nsINetworkConnectivityService,
public nsIObserver,
public nsIDNSListener,
public nsIStreamListener {
public:
NS_DECL_ISUPPORTS
NS_DECL_NSINETWORKCONNECTIVITYSERVICE
NS_DECL_NSIOBSERVER
NS_DECL_NSIDNSLISTENER
NS_DECL_NSISTREAMLISTENER
NS_DECL_NSIREQUESTOBSERVER
nsresult Init();
static already_AddRefed<NetworkConnectivityService> GetSingleton();
private:
NetworkConnectivityService() = default;
virtual ~NetworkConnectivityService() = default;
// Calls all the check methods
void PerformChecks();
// Will be set to OK if the DNS request returned in IP of this type,
// NOT_AVAILABLE if that type of resolution is not available
// UNKNOWN if the check wasn't performed
ConnectivityState mDNSv4 = nsINetworkConnectivityService::UNKNOWN;
ConnectivityState mDNSv6 = nsINetworkConnectivityService::UNKNOWN;
ConnectivityState mIPv4 = nsINetworkConnectivityService::UNKNOWN;
ConnectivityState mIPv6 = nsINetworkConnectivityService::UNKNOWN;
nsCOMPtr<nsICancelable> mDNSv4Request;
nsCOMPtr<nsICancelable> mDNSv6Request;
nsCOMPtr<nsIChannel> mIPv4Channel;
nsCOMPtr<nsIChannel> mIPv6Channel;
};
} // namespace net
} // namespace mozilla
#endif // NetworkConnectivityService_h_