gecko-dev/dom/bindings/CallbackInterface.cpp
Jon Coppeard d12ca3002f Bug 1632439 - Make CallbackObject methods return JSObject pointers rather than handles r=peterv
This turned out to be simpler than expected. Apart from generated bindings, a lot of the callers didn't make use of the fact that the return value was a handle.

Differential Revision: https://phabricator.services.mozilla.com/D72120
2020-05-21 14:09:02 +00:00

36 lines
1.2 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/dom/CallbackInterface.h"
#include "jsapi.h"
#include "js/CharacterEncoding.h"
#include "mozilla/dom/BindingUtils.h"
#include "nsPrintfCString.h"
namespace mozilla {
namespace dom {
bool CallbackInterface::GetCallableProperty(
BindingCallContext& cx, JS::Handle<jsid> aPropId,
JS::MutableHandle<JS::Value> aCallable) {
JS::Rooted<JSObject*> obj(cx, CallbackKnownNotGray());
if (!JS_GetPropertyById(cx, obj, aPropId, aCallable)) {
return false;
}
if (!aCallable.isObject() || !JS::IsCallable(&aCallable.toObject())) {
JS::RootedString propId(cx, JSID_TO_STRING(aPropId));
JS::UniqueChars propName = JS_EncodeStringToUTF8(cx, propId);
nsPrintfCString description("Property '%s'", propName.get());
cx.ThrowErrorMessage<MSG_NOT_CALLABLE>(description.get());
return false;
}
return true;
}
} // namespace dom
} // namespace mozilla