gecko-dev/devtools/shared/layout
Julian Descottes 34f1606151 Bug 1583444 - Stop using win.top in devtools/shared/layout/utils.js r=pbro
Depends on D46957

We are updating three call sites that were still relying on window.top to get the topmost window.

For `getFrameOffsets` and `getRect`, they are currently only called with a non-null `boundaryWindow` argument.
That's why this didn't trigger any regression.

For `getFrameElement`, I could only find STRs that don't have any user impact.
For instance, when the BrowserToolbox debugs a page where you open DevTools, this will load the toolbox in an iframe.
This load will trigger `onFrameLoad` in the walker actor. And because we were using `win.top`, getFrameElement would return null, and onFrameLoad will not emit mutations.
But I couldn't see any scenario where this had an actual impact for users.

Differential Revision: https://phabricator.services.mozilla.com/D46958

--HG--
extra : moz-landing-system : lando
2019-09-30 09:53:15 +00:00
..
dom-matrix-2d.js Bug 1561435 - Format remaining devtools/, a=automatic-formatting, CLOSED TREE 2019-07-05 11:29:32 +02:00
moz.build
utils.js Bug 1583444 - Stop using win.top in devtools/shared/layout/utils.js r=pbro 2019-09-30 09:53:15 +00:00