mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-11 16:32:59 +00:00
390c6943fe
This shouldn't change behavior, but is the biggest cross-platform part
of the change so I'd like to get it landed sooner rather than later.
The two calls like:
GetColor(ColorID::TextSelectBackground, color);
if (color == 0x000000) {
mColorTextSelectForeground = NS_RGB(0xff, 0xff, 0xff);
} else {
mColorTextSelectForeground = NS_DONT_CHANGE_COLOR;
}
that I'm removing are just broken. They were calling the version of
GetColor the function that took a default value when the color wasn't
available, not the version of the color with the outparam.
To prevent such mistakes, add two signatures, GetColor(), returning a
Maybe<nscolor> and Color(), returning a color with a fallback.
Differential Revision: https://phabricator.services.mozilla.com/D110651
|
||
|---|---|---|
| .. | ||
| crashtests | ||
| reftests | ||
| test | ||
| BasicTableLayoutStrategy.cpp | ||
| BasicTableLayoutStrategy.h | ||
| celldata.h | ||
| FixedTableLayoutStrategy.cpp | ||
| FixedTableLayoutStrategy.h | ||
| moz.build | ||
| nsCellMap.cpp | ||
| nsCellMap.h | ||
| nsITableCellLayout.h | ||
| nsITableLayoutStrategy.h | ||
| nsTableCellFrame.cpp | ||
| nsTableCellFrame.h | ||
| nsTableColFrame.cpp | ||
| nsTableColFrame.h | ||
| nsTableColGroupFrame.cpp | ||
| nsTableColGroupFrame.h | ||
| nsTableFrame.cpp | ||
| nsTableFrame.h | ||
| nsTableRowFrame.cpp | ||
| nsTableRowFrame.h | ||
| nsTableRowGroupFrame.cpp | ||
| nsTableRowGroupFrame.h | ||
| nsTableWrapperFrame.cpp | ||
| nsTableWrapperFrame.h | ||
| SpanningCellSorter.cpp | ||
| SpanningCellSorter.h | ||
| TableArea.h | ||