gecko-dev/dom/media/gmp/GMPMemoryStorage.cpp
Chris Pearce ad956f902f Bug 1268984 - Store GMPStorage on GMPServiceParent so that it persists inside the same PB session. r=gerald
Prior to this change, we'd store the GMPStorage records for private browsing
sessions in the GMPStorageParent. The problem with this is that they only have
a lifespan matching their corresponding GMPParent. This means that if a GMP
stores something in a PB session, and the GMP is shutdown and then re-created,
we are likely to loose the stored data. This could mean that the PB session
gets results it doesn't expect, and thus expose a way for PB mode to be
detected.


MozReview-Commit-ID: 1OMD0LvidYs

--HG--
extra : rebase_source : 75661a7b1717e39a29c3e12ad203d9273e8485ab
2016-05-05 11:41:33 +12:00

96 lines
2.3 KiB
C++

/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "GMPStorage.h"
#include "nsClassHashtable.h"
namespace mozilla {
namespace gmp {
class GMPMemoryStorage : public GMPStorage {
public:
GMPErr Open(const nsCString& aRecordName) override
{
MOZ_ASSERT(!IsOpen(aRecordName));
Record* record = nullptr;
if (!mRecords.Get(aRecordName, &record)) {
record = new Record();
mRecords.Put(aRecordName, record);
}
record->mIsOpen = true;
return GMPNoErr;
}
bool IsOpen(const nsCString& aRecordName) const override {
const Record* record = mRecords.Get(aRecordName);
if (!record) {
return false;
}
return record->mIsOpen;
}
GMPErr Read(const nsCString& aRecordName,
nsTArray<uint8_t>& aOutBytes) override
{
const Record* record = mRecords.Get(aRecordName);
if (!record) {
return GMPGenericErr;
}
aOutBytes = record->mData;
return GMPNoErr;
}
GMPErr Write(const nsCString& aRecordName,
const nsTArray<uint8_t>& aBytes) override
{
Record* record = nullptr;
if (!mRecords.Get(aRecordName, &record)) {
return GMPClosedErr;
}
record->mData = aBytes;
return GMPNoErr;
}
GMPErr GetRecordNames(nsTArray<nsCString>& aOutRecordNames) const override
{
for (auto iter = mRecords.ConstIter(); !iter.Done(); iter.Next()) {
aOutRecordNames.AppendElement(iter.Key());
}
return GMPNoErr;
}
void Close(const nsCString& aRecordName) override
{
Record* record = nullptr;
if (!mRecords.Get(aRecordName, &record)) {
return;
}
if (!record->mData.Length()) {
// Record is empty, delete.
mRecords.Remove(aRecordName);
} else {
record->mIsOpen = false;
}
}
private:
struct Record {
nsTArray<uint8_t> mData;
bool mIsOpen = false;
};
nsClassHashtable<nsCStringHashKey, Record> mRecords;
};
already_AddRefed<GMPStorage> CreateGMPMemoryStorage()
{
return RefPtr<GMPStorage>(new GMPMemoryStorage()).forget();
}
} // namespace gmp
} // namespace mozilla