gecko-dev/dom
Alastor Wu f74da16941 Bug 1580659 - part3 : call 'WindowAudioCaptureChanged()' explicitly. r=chunmin,karlt
Previously `AudioChannelService` called `WindowAudioCaptureChanged()` implicitly whenever we added the agent to the service [1], which made the audio capturing callback happen before finishing registration.

There are two drawbacks,
(1) it's hard to be aware of that the audio capturing callback would be called before finishing `AudioChannelAgent::NotifyStartedPlaying()` [2], which causes unclear call flow.

(2) If someone checks `AudioChannelAgent::IsPlayingStarted()` [3] inside audio capturing callback, then we would find that the `mIsRegToService` is false even if we have registered the agent to `AudioChannelService` because `mIsRegToService` is updated in the last line in the `AudioChannelAgent::NotifyStartedPlaying()`, but the audio capturing callback could be executed before that.

[1] https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/dom/audiochannel/AudioChannelService.cpp#723
[2] https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/dom/audiochannel/AudioChannelAgent.cpp#144
[3] https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/dom/audiochannel/AudioChannelAgent.cpp#285

Differential Revision: https://phabricator.services.mozilla.com/D45750

--HG--
extra : moz-landing-system : lando
2019-09-18 21:59:32 +00:00
..
abort
animation Bug 1567330 - Add offset shorthand. r=emilio,birtles 2019-09-23 19:56:33 +00:00
audiochannel Bug 1580659 - part3 : call 'WindowAudioCaptureChanged()' explicitly. r=chunmin,karlt 2019-09-18 21:59:32 +00:00
base Bug 1575138 - Don't bother scheduling a reconstruct on <slot>s that have no fallback. r=smaug 2019-09-24 00:03:39 +00:00
battery
bindings Bug 1582538. Fix mixin exposure set computation when interfaces that include it have no explicit exposure sets. r=saschanaz 2019-09-24 02:32:14 +00:00
broadcastchannel
browser-element
cache Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug 2019-09-20 02:19:18 +00:00
canvas Bug 1582884 - Enable some crashtests on Android; r=geckoview-reviewers,agi 2019-09-24 01:12:09 +00:00
chrome-webidl Bug 1575306 - Suppress reporting of uncaught testing sentinel, r=bzbarsky. 2019-09-16 20:17:17 +00:00
clients Bug 1511033 - Support ServiceWorkerClients.openWindow() r=geckoview-reviewers,snorp,smaug 2019-09-18 11:29:30 +00:00
commandhandler
console Bug 1578623 move principal-related data from LoadInfo to WorkletImpl r=baku 2019-09-09 00:42:05 +00:00
credentialmanagement
crypto Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden 2019-09-18 08:26:34 +00:00
debugger
docs Bug 1580907 - Remove transferables attribute for SendAsyncMessage and SendQuery in JSWindowActor; r=nika 2019-09-13 16:51:23 +00:00
encoding Bug 1561573 - Avoid linearization and inflation to UTF-16 of the string input to TextEncoder. r=jandem,bzbarsky 2019-09-18 08:26:52 +00:00
events Bug 1552041 - Part 1. Set CAUSE_UNKNOWN_CHROME if caller is chrome script or native. r=masayuki 2019-09-23 07:22:03 +00:00
fetch Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug 2019-09-20 20:51:25 +00:00
file Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden 2019-09-18 08:26:34 +00:00
filehandle
filesystem
flex Bug 1563163 Part 1: Make Flex::Flex gracefully handle frames without FlexContainerInfo structures. r=mats 2019-08-30 23:16:09 +00:00
gamepad Bug 1579492 - Check if nullptr in DarwinGamepadService::ReportChangedCallback(). r=baku 2019-09-09 11:58:01 +00:00
geolocation Backed out changeset 493061169650 (bug 1529591) for build bustages on nsGeolocation.cpp. CLOSED TREE 2019-09-09 17:35:39 +03:00
grid Bug 1308587 Part 1 - Manually remove "-moz" prefixed multi-column properties in some tests. r=dholbert 2019-09-05 21:32:05 +00:00
html Bug 1580659 - part3 : call 'WindowAudioCaptureChanged()' explicitly. r=chunmin,karlt 2019-09-18 21:59:32 +00:00
imptests
indexedDB Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug 2019-09-20 02:19:18 +00:00
interfaces Bug 1580710: Expose functionality on the CSP Object to allow skipping the inline style checks. r=bzbarsky 2019-09-16 23:47:19 +00:00
ipc Bug 1583378 - Remove unneded warning in do_QueryActor. r=kmag 2019-09-23 22:32:37 +00:00
jsurl Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden 2019-09-18 08:26:34 +00:00
l10n Bug 1580991 - Trigger DOMLocalization::OnChange from Localization::Observe. r=smaug 2019-09-13 10:08:26 +00:00
locales Bug 1570681 - Enforce eval restrictions in system contexts and the parent process r=ckerschb 2019-09-19 02:32:41 +00:00
localstorage Bug 1576260 - Make LSValue initialization fallible; r=asuth 2019-09-14 05:33:01 +00:00
manifest Bug 1575140 - Manifest ImageResource sizes should be an array r=baku 2019-08-21 10:29:16 +00:00
mathml Bug 1579602 - Rename nsMathMLElement to dom::MathMLElement. r=bzbarsky 2019-09-13 16:27:54 +00:00
media Bug 1580659 - part3 : call 'WindowAudioCaptureChanged()' explicitly. r=chunmin,karlt 2019-09-18 21:59:32 +00:00
messagechannel Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika 2019-09-20 10:18:15 -07:00
midi
network Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug 2019-09-20 02:19:18 +00:00
notification Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug 2019-09-20 02:19:18 +00:00
offline
payments Bug 1582196 part 3. Stop using NS_ERROR_RANGE_ERR and NS_ERROR_TYPE_ERR in payments code. r=edenchuang 2019-09-19 23:53:14 +00:00
performance Bug 1578329 - Use profiler_can_accept_markers() where appropriate - r=gregtatum 2019-09-18 01:22:12 +00:00
permission Bug 1560570- FeaturePolicy should be considered when permissions.query() is called r=baku,johannh 2019-09-21 08:38:26 +00:00
plugins Bug 1582884 - Enable some crashtests on Android; r=geckoview-reviewers,agi 2019-09-24 01:12:09 +00:00
power
presentation
prio Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv 2019-09-23 19:14:33 +00:00
promise Bug 1575744 - P4. Add MozPromise::FromDomPromise. r=bholley 2019-09-20 04:09:46 +00:00
prototype Bug 1575620 - Fix refreshing session restore when using prototype cache. r=smaug 2019-09-06 20:27:09 +00:00
push Backed out changeset a956d11fef6e (bug 1369436) for XPCshell failure on dom/push/test/xpcshell/test_notification_http2.js 2019-09-13 00:42:28 +03:00
quota Bug 1581278 part 3. Stop incorrectly rejecting promises in storage manager. r=janv 2019-09-19 18:18:28 +00:00
reporting Bug 1578173 part 6. Remove remaining uses of [Constructor] from bindings. r=edgar 2019-09-12 11:01:17 +00:00
res
script Bug 1579876 - Add telemetry to estimate the benefit of a streaming parser for JS. data-review=mlopatka r=jorendorff 2019-09-19 12:42:51 +00:00
security Bug 1580771 - Set test_main.html to always fail on fission r=neha 2019-09-19 13:26:22 +00:00
serviceworkers Bug 1581315 part 3. Add MOZ_MUST_RETURN_FROM_CALLER_IF_THIS_IS_ARG to more ErrorResult methods. r=smaug 2019-09-20 02:19:18 +00:00
simpledb Bug 1563023 - Part 3: Change client usage type to support the null value; r=asuth 2019-08-22 20:52:09 +00:00
smil Bug 1574222 - Serialize getComputedStyle on text-decoration properly. r=emilio,dholbert 2019-09-10 21:52:26 +00:00
storage Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv 2019-09-23 19:14:33 +00:00
svg Bug 1578098 - move DOM classes to DOM namespace and eliminate using namespace mozilla r=dholbert 2019-09-21 14:38:56 +00:00
system Bug 1580900 - Part 1 - Extend nsIOSPermissionRequest to support screen-recording permission checks r=spohl 2019-09-17 22:13:36 +00:00
tests Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi 2019-09-23 22:43:55 +00:00
u2f Bug 1577746 - Enable ESLint rule object-shorthand for dom/. r=baku 2019-09-02 11:22:27 +00:00
url
vr Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug 2019-09-20 20:51:25 +00:00
webauthn Bug 1573245 - Change AuthenticatorTransport to be string, not enum r=bzbarsky,keeler 2019-09-17 07:50:44 +00:00
webbrowserpersist
webgpu
webidl Bug 1578355 - Part 3: Add the ability to consume transient user activation; r=smaug 2019-09-20 11:10:13 +00:00
websocket Bug 1579820 - Handle window.open() from remote subframes. r=nika 2019-09-10 09:04:17 +00:00
workers Bug 1581315 part 1. Adjust MOZ_MUST_RETURN_FROM_CALLER to only apply to method calls on arguments. r=nika 2019-09-20 02:17:01 +00:00
worklet Bug 1578623 use an opaque origin for WorkletGlobalScope r=baku 2019-09-09 00:42:01 +00:00
xbl Bug 1582884 - Enable some crashtests on Android; r=geckoview-reviewers,agi 2019-09-24 01:12:09 +00:00
xhr Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug 2019-09-20 20:51:25 +00:00
xml Bug 1575620 - Fix refreshing session restore when using prototype cache. r=smaug 2019-09-06 20:27:09 +00:00
xslt Bug 1578173 part 6. Remove remaining uses of [Constructor] from bindings. r=edgar 2019-09-12 11:01:17 +00:00
xul Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika 2019-09-20 10:18:15 -07:00
jar.mn
moz.build Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj 2019-08-21 12:25:42 +00:00