mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-25 13:51:41 +00:00
256c124f94
This was done by: This was done by applying: ``` diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py index 789affde7bbf..fe33c4c7d4d1 100644 --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase): from subprocess import Popen, PIPE, check_output, CalledProcessError diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE) - args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format] + args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes'] if not output_file: args.append("-i") ``` Then running `./mach clang-format -c <commit-hash>` Then undoing that patch. Then running check_spidermonkey_style.py --fixup Then running `./mach clang-format` I had to fix four things: * I needed to move <utility> back down in GuardObjects.h because I was hitting obscure problems with our system include wrappers like this: 0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration 0:03.94 extern void *realloc (void *__ptr, size_t __size) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here 0:03.94 MALLOC_DECL(realloc, void*, void*, size_t) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL' 0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__); 0:03.94 ^ 0:03.94 <scratch space>:178:1: note: expanded from here 0:03.94 realloc_impl 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl' 0:03.94 #define realloc_impl mozmem_malloc_impl(realloc) Which I really didn't feel like digging into. * I had to restore the order of TrustOverrideUtils.h and related files in nss because the .inc files depend on TrustOverrideUtils.h being included earlier. * I had to add a missing include to RollingNumber.h * Also had to partially restore include order in JsepSessionImpl.cpp to avoid some -WError issues due to some static inline functions being defined in a header but not used in the rest of the compilation unit. Differential Revision: https://phabricator.services.mozilla.com/D60327 --HG-- extra : moz-landing-system : lando
143 lines
4.0 KiB
C++
143 lines
4.0 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef mozilla_gfx_2d_CaptureCommandList_h
|
|
#define mozilla_gfx_2d_CaptureCommandList_h
|
|
|
|
#include <limits>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "DrawCommand.h"
|
|
#include "Logging.h"
|
|
#include "mozilla/PodOperations.h"
|
|
|
|
// Command object is stored into record with header containing size and
|
|
// redundant size of whole record. Some platforms may require Command
|
|
// object to be stored on 8 bytes aligned address. Therefore we need to
|
|
// adjust size of header for these platforms.
|
|
#ifdef __sparc__
|
|
typedef uint32_t kAdvance_t;
|
|
#else
|
|
typedef uint16_t kAdvance_t;
|
|
#endif
|
|
|
|
namespace mozilla {
|
|
namespace gfx {
|
|
|
|
class CaptureCommandList {
|
|
public:
|
|
CaptureCommandList() : mLastCommand(nullptr) {}
|
|
CaptureCommandList(CaptureCommandList&& aOther)
|
|
: mStorage(std::move(aOther.mStorage)),
|
|
mLastCommand(aOther.mLastCommand) {
|
|
aOther.mLastCommand = nullptr;
|
|
}
|
|
~CaptureCommandList();
|
|
|
|
CaptureCommandList& operator=(CaptureCommandList&& aOther) {
|
|
mStorage = std::move(aOther.mStorage);
|
|
mLastCommand = aOther.mLastCommand;
|
|
aOther.mLastCommand = nullptr;
|
|
return *this;
|
|
}
|
|
|
|
template <typename T>
|
|
T* Append() {
|
|
static_assert(sizeof(T) + 2 * sizeof(kAdvance_t) <=
|
|
std::numeric_limits<kAdvance_t>::max(),
|
|
"encoding is too small to contain advance");
|
|
const kAdvance_t kAdvance = sizeof(T) + 2 * sizeof(kAdvance_t);
|
|
|
|
size_t size = mStorage.size();
|
|
mStorage.resize(size + kAdvance);
|
|
|
|
uint8_t* current = &mStorage.front() + size;
|
|
*(kAdvance_t*)(current) = kAdvance;
|
|
current += sizeof(kAdvance_t);
|
|
*(kAdvance_t*)(current) = ~kAdvance;
|
|
current += sizeof(kAdvance_t);
|
|
|
|
T* command = reinterpret_cast<T*>(current);
|
|
mLastCommand = command;
|
|
return command;
|
|
}
|
|
|
|
template <typename T>
|
|
T* ReuseOrAppend() {
|
|
{ // Scope lock
|
|
if (mLastCommand != nullptr && mLastCommand->GetType() == T::Type) {
|
|
return reinterpret_cast<T*>(mLastCommand);
|
|
}
|
|
}
|
|
return Append<T>();
|
|
}
|
|
|
|
bool IsEmpty() const { return mStorage.empty(); }
|
|
|
|
template <typename T>
|
|
bool BufferWillAlloc() const {
|
|
const kAdvance_t kAdvance = sizeof(T) + 2 * sizeof(kAdvance_t);
|
|
return mStorage.size() + kAdvance > mStorage.capacity();
|
|
}
|
|
|
|
size_t BufferCapacity() const { return mStorage.capacity(); }
|
|
|
|
void Clear();
|
|
|
|
class iterator {
|
|
public:
|
|
explicit iterator(CaptureCommandList& aParent)
|
|
: mParent(aParent), mCurrent(nullptr), mEnd(nullptr) {
|
|
if (!mParent.mStorage.empty()) {
|
|
mCurrent = &mParent.mStorage.front();
|
|
mEnd = mCurrent + mParent.mStorage.size();
|
|
}
|
|
}
|
|
|
|
bool Done() const { return mCurrent >= mEnd; }
|
|
void Next() {
|
|
MOZ_ASSERT(!Done());
|
|
kAdvance_t advance = *reinterpret_cast<kAdvance_t*>(mCurrent);
|
|
kAdvance_t redundant =
|
|
~*reinterpret_cast<kAdvance_t*>(mCurrent + sizeof(kAdvance_t));
|
|
MOZ_RELEASE_ASSERT(advance == redundant);
|
|
mCurrent += advance;
|
|
}
|
|
DrawingCommand* Get() {
|
|
MOZ_ASSERT(!Done());
|
|
return reinterpret_cast<DrawingCommand*>(mCurrent +
|
|
2 * sizeof(kAdvance_t));
|
|
}
|
|
|
|
private:
|
|
CaptureCommandList& mParent;
|
|
uint8_t* mCurrent;
|
|
uint8_t* mEnd;
|
|
};
|
|
|
|
void Log(TreeLog<>& aStream) {
|
|
for (iterator iter(*this); !iter.Done(); iter.Next()) {
|
|
DrawingCommand* cmd = iter.Get();
|
|
cmd->Log(aStream);
|
|
aStream << "\n";
|
|
}
|
|
}
|
|
|
|
private:
|
|
CaptureCommandList(const CaptureCommandList& aOther) = delete;
|
|
void operator=(const CaptureCommandList& aOther) = delete;
|
|
|
|
private:
|
|
std::vector<uint8_t> mStorage;
|
|
DrawingCommand* mLastCommand;
|
|
};
|
|
|
|
} // namespace gfx
|
|
} // namespace mozilla
|
|
|
|
#endif // mozilla_gfx_2d_CaptureCommandList_h
|