mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 16:25:38 +00:00
933b3522b8
`ply`, [by design](https://github.com/dabeaz/ply/issues/79), does not produce reproducible table files; hence bug 1633156. (Note that this was *always* true, but only became a problem once we switched to Python 3, which has more unpredictable dict iteration order than Python 2.7, at least prior to [3.7](https://docs.python.org/3/whatsnew/3.7.html#summary-release-highlights).)
In any other circumstance I would consider submitting a patch to `ply` to fix this, but as of the [in-progress version 4.0 of the library](https://github.com/dabeaz/ply/blob/master/CHANGES), it doesn't even emit this cached data any more, and indeed the [latest version of the code](1fac9fed64/ply) doesn't even call `open()` at all except to do logging or to read the text data to be parsed from `stdin`. So if we were going to pin our future on `ply` and upgrade to later versions of the library in the future, we would have to live in a world where `ply` doesn't generate cached table files for us anyway.
Emitting the cached table files so later build steps can consume them is an "optimization", but it's not clear exactly how much actual value that optimization provides overall. Quoth the `CHANGES` file from that repository:
```
PLY no longer writes cached table files. Honestly, the use of
the cached files made more sense when I was developing PLY on
my 200Mhz PC in 2001. It's not as much as an issue now. For small
to medium sized grammars, PLY should be almost instantaneous.
```
In practice, I have found this to be true; namely, `./mach build pre-export export` takes just about as long on my machine after this patch as it did before, and in a try push I performed, there's no noticeable performance regression from applying this patch. In local testing I also found that generating the LALR tables in calls to `yacc()` takes about 0.01s on my machine generally, and we generate these tables a couple dozen times total over the course of the `export` tier now. This isn't *nothing*, but in my opinion it's also not nearly long enough where it would be a concern given how long `export` already takes.
That `CHANGES` file also stresses that if caching this data is important, we have the option of doing so via `pickle`. If and when we decide that re-enabling this optimization is valuable for us, we should take control of this process and perform the generation in such a way that we can guarantee reproducibility.
Differential Revision: https://phabricator.services.mozilla.com/D73484
248 lines
8.9 KiB
Makefile
248 lines
8.9 KiB
Makefile
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
# You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
ifndef INCLUDED_RULES_MK
|
|
include $(topsrcdir)/config/rules.mk
|
|
endif
|
|
|
|
# The traditional model of directory traversal with make is as follows:
|
|
# make -C foo
|
|
# Entering foo
|
|
# make -C bar
|
|
# Entering foo/bar
|
|
# make -C baz
|
|
# Entering foo/baz
|
|
# make -C qux
|
|
# Entering qux
|
|
#
|
|
# Pseudo derecurse transforms the above into:
|
|
# make -C foo
|
|
# make -C foo/bar
|
|
# make -C foo/baz
|
|
# make -C qux
|
|
|
|
ifeq (.,$(DEPTH))
|
|
|
|
include root.mk
|
|
|
|
# Main rules (export, compile, libs and tools) call recurse_* rules.
|
|
# This wrapping is only really useful for build status.
|
|
$(RUNNABLE_TIERS)::
|
|
$(if $(filter $@,$(MAKECMDGOALS)),$(call BUILDSTATUS,TIERS $@),)
|
|
$(call BUILDSTATUS,TIER_START $@)
|
|
+$(MAKE) recurse_$@
|
|
$(call BUILDSTATUS,TIER_FINISH $@)
|
|
|
|
# Special rule that does install-manifests (cf. Makefile.in) + compile
|
|
binaries::
|
|
+$(MAKE) recurse_compile
|
|
|
|
# Carefully avoid $(eval) type of rule generation, which makes pymake slower
|
|
# than necessary.
|
|
# Get current tier and corresponding subtiers from the data in root.mk.
|
|
CURRENT_TIER := $(filter $(foreach tier,$(RUNNABLE_TIERS) $(non_default_tiers),recurse_$(tier) $(tier)-deps),$(MAKECMDGOALS))
|
|
ifneq (,$(filter-out 0 1,$(words $(CURRENT_TIER))))
|
|
$(error $(CURRENT_TIER) not supported on the same make command line)
|
|
endif
|
|
CURRENT_TIER := $(subst recurse_,,$(CURRENT_TIER:-deps=))
|
|
|
|
# The rules here are doing directory traversal, so we don't want further
|
|
# recursion to happen when running make -C subdir $tier. But some make files
|
|
# further call make -C something else, and sometimes expect recursion to
|
|
# happen in that case.
|
|
# Conveniently, every invocation of make increases MAKELEVEL, so only stop
|
|
# recursion from happening at current MAKELEVEL + 1.
|
|
ifdef CURRENT_TIER
|
|
ifeq (0,$(MAKELEVEL))
|
|
export NO_RECURSE_MAKELEVEL=1
|
|
else
|
|
export NO_RECURSE_MAKELEVEL=$(word $(MAKELEVEL),2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20)
|
|
endif
|
|
endif
|
|
|
|
RECURSE = $(if $(RECURSE_TRACE_ONLY),@echo $2/$1,$(call SUBMAKE,$1,$2))
|
|
|
|
# Use the $(*_dirs) variables available in root.mk
|
|
CURRENT_DIRS := $($(CURRENT_TIER)_dirs)
|
|
|
|
# Need a list of compile targets because we can't use pattern rules:
|
|
# https://savannah.gnu.org/bugs/index.php?42833
|
|
# Only recurse the paths starting with RECURSE_BASE_DIR when provided.
|
|
.PHONY: $(compile_targets) $(syms_targets)
|
|
$(compile_targets) $(syms_targets):
|
|
$(if $(filter $(RECURSE_BASE_DIR)%,$@),$(call RECURSE,$(@F),$(@D)))
|
|
|
|
$(syms_targets): %/syms: %/target
|
|
|
|
# Only hook symbols targets into the main compile graph in automation.
|
|
ifdef MOZ_AUTOMATION
|
|
ifeq (1,$(MOZ_AUTOMATION_BUILD_SYMBOLS))
|
|
recurse_compile: $(syms_targets)
|
|
endif
|
|
endif
|
|
|
|
# Create a separate rule that depends on every 'syms' target so that
|
|
# symbols can be dumped on demand locally.
|
|
.PHONY: recurse_syms
|
|
recurse_syms: $(syms_targets)
|
|
|
|
# Ensure dump_syms gets built before any syms targets, all of which depend on it.
|
|
ifneq (,$(filter toolkit/crashreporter/google-breakpad/src/tools/%/dump_syms/host,$(compile_targets)))
|
|
$(syms_targets): $(filter toolkit/crashreporter/google-breakpad/src/tools/%/dump_syms/host,$(compile_targets))
|
|
endif
|
|
|
|
# The compile tier has different rules from other tiers.
|
|
ifneq ($(CURRENT_TIER),compile)
|
|
|
|
# Recursion rule for all directories traversed for all subtiers in the
|
|
# current tier.
|
|
$(addsuffix /$(CURRENT_TIER),$(CURRENT_DIRS)): %/$(CURRENT_TIER):
|
|
$(call RECURSE,$(CURRENT_TIER),$*)
|
|
|
|
.PHONY: $(addsuffix /$(CURRENT_TIER),$(CURRENT_DIRS))
|
|
|
|
# Dummy rules for possibly inexisting dependencies for the above tier targets
|
|
$(addsuffix /Makefile,$(CURRENT_DIRS)) $(addsuffix /backend.mk,$(CURRENT_DIRS)):
|
|
|
|
ifeq ($(CURRENT_TIER),export)
|
|
# At least build/export requires config/export for buildid, but who knows what
|
|
# else, so keep this global dependency to make config/export first for now.
|
|
$(addsuffix /$(CURRENT_TIER),$(filter-out config,$(CURRENT_DIRS))): config/$(CURRENT_TIER)
|
|
|
|
# The export tier requires nsinstall, which is built from config. So every
|
|
# subdirectory traversal needs to happen after building nsinstall in config, which
|
|
# is done with the config/host target. Note the config/host target only exists if
|
|
# nsinstall is actually built, which it is not on Windows, because we use
|
|
# nsinstall.py there.
|
|
ifdef COMPILE_ENVIRONMENT
|
|
ifneq (,$(filter config/host, $(compile_targets)))
|
|
$(addsuffix /$(CURRENT_TIER),$(CURRENT_DIRS)): config/host
|
|
endif
|
|
endif
|
|
endif
|
|
|
|
endif # ifeq ($(CURRENT_TIER),compile)
|
|
|
|
else
|
|
|
|
# Don't recurse if MAKELEVEL is NO_RECURSE_MAKELEVEL as defined above
|
|
ifeq ($(NO_RECURSE_MAKELEVEL),$(MAKELEVEL))
|
|
|
|
$(RUNNABLE_TIERS)::
|
|
|
|
else
|
|
#########################
|
|
# Tier traversal handling
|
|
#########################
|
|
|
|
define CREATE_SUBTIER_TRAVERSAL_RULE
|
|
.PHONY: $(1)
|
|
|
|
$(1):: $$(SUBMAKEFILES)
|
|
$$(LOOP_OVER_DIRS)
|
|
|
|
endef
|
|
|
|
$(foreach subtier,$(filter-out compile,$(RUNNABLE_TIERS)),$(eval $(call CREATE_SUBTIER_TRAVERSAL_RULE,$(subtier))))
|
|
|
|
ifndef TOPLEVEL_BUILD
|
|
ifdef COMPILE_ENVIRONMENT
|
|
compile::
|
|
@$(MAKE) -C $(DEPTH) compile RECURSE_BASE_DIR=$(relativesrcdir)/
|
|
endif # COMPILE_ENVIRONMENT
|
|
endif
|
|
|
|
endif # ifeq ($(NO_RECURSE_MAKELEVEL),$(MAKELEVEL))
|
|
|
|
endif # ifeq (.,$(DEPTH))
|
|
|
|
recurse:
|
|
@$(RECURSED_COMMAND)
|
|
$(LOOP_OVER_DIRS)
|
|
|
|
ifeq (.,$(DEPTH))
|
|
# Interdependencies for parallel export.
|
|
js/xpconnect/src/export: dom/bindings/export xpcom/xpidl/export
|
|
accessible/xpcom/export: xpcom/xpidl/export
|
|
|
|
# The Android SDK bindings needs to build the Java generator code
|
|
# source code in order to write the SDK bindings.
|
|
widget/android/bindings/export: mobile/android/base/export
|
|
|
|
# The widget JNI wrapper generator code needs to build the GeckoView
|
|
# source code in order to find JNI wrapper annotations.
|
|
widget/android/export: mobile/android/base/export
|
|
|
|
# CSS2Properties.webidl needs ServoCSSPropList.py from layout/style
|
|
dom/bindings/export: layout/style/export
|
|
|
|
# Various telemetry histogram files need ServoCSSPropList.py from layout/style
|
|
toolkit/components/telemetry/export: layout/style/export
|
|
|
|
# The update agent needs to link to the updatecommon library, but the build system does not
|
|
# currently have a good way of expressing this dependency.
|
|
toolkit/components/updateagent/target: toolkit/mozapps/update/common/target
|
|
|
|
ifdef ENABLE_CLANG_PLUGIN
|
|
# Only target rules use the clang plugin.
|
|
$(filter %/target %/target-objects,$(filter-out config/export config/host build/unix/stdc++compat/% build/clang-plugin/%,$(compile_targets))): build/clang-plugin/host build/clang-plugin/tests/target-objects
|
|
build/clang-plugin/tests/target-objects: build/clang-plugin/host
|
|
# clang-plugin tests require js-confdefs.h on js standalone builds and mozilla-config.h on
|
|
# other builds, because they are -include'd.
|
|
ifdef JS_STANDALONE
|
|
# The js/src/export target only exists when CURRENT_TIER is export. If we're in a later tier,
|
|
# we can assume js/src/export has happened anyways.
|
|
ifeq ($(CURRENT_TIER),export)
|
|
build/clang-plugin/tests/target-objects: js/src/export
|
|
endif
|
|
else
|
|
build/clang-plugin/tests/target-objects: mozilla-config.h
|
|
endif
|
|
endif
|
|
|
|
# Interdependencies that moz.build world don't know about yet for compilation.
|
|
# Note some others are hardcoded or "guessed" in recursivemake.py and emitter.py
|
|
ifeq ($(MOZ_WIDGET_TOOLKIT),gtk)
|
|
toolkit/library/target: widget/gtk/mozgtk/gtk3/target
|
|
endif
|
|
|
|
ifndef MOZ_FOLD_LIBS
|
|
ifndef MOZ_SYSTEM_NSS
|
|
netwerk/test/http3server/target: security/nss/lib/nss/nss_nss3/target security/nss/lib/ssl/ssl_ssl3/target
|
|
endif
|
|
ifndef MOZ_SYSTEM_NSPR
|
|
netwerk/test/http3server/target: config/external/nspr/pr/target
|
|
endif
|
|
else
|
|
ifndef MOZ_SYSTEM_NSS
|
|
netwerk/test/http3server/target: security/target
|
|
endif
|
|
endif
|
|
|
|
# Most things are built during compile (target/host), but some things happen during export
|
|
# Those need to depend on config/export for system wrappers.
|
|
$(addprefix build/unix/stdc++compat/,target host) build/clang-plugin/host: config/export
|
|
|
|
# Rust targets, and export targets that run cbindgen need
|
|
# $topobjdir/.cargo/config to be preprocessed first. Ideally, we'd only set it
|
|
# as a dependency of the rust targets, but unfortunately, that pushes Make to
|
|
# execute them much later than we'd like them to be when the file doesn't exist
|
|
# prior to Make running. So we also set it as a dependency of pre-export, which
|
|
# ensures it exists before recursing the rust targets and the export targets
|
|
# that run cbindgen, tricking Make into keeping them early.
|
|
$(rust_targets) gfx/webrender_bindings/export layout/style/export xpcom/base/export: $(DEPTH)/.cargo/config
|
|
ifndef TEST_MOZBUILD
|
|
pre-export:: $(DEPTH)/.cargo/config
|
|
endif
|
|
|
|
# When building gtest as part of the build (LINK_GTEST_DURING_COMPILE),
|
|
# force the build system to get to it first, so that it can be linked
|
|
# quickly without LTO, allowing the build system to go ahead with
|
|
# plain gkrust and libxul while libxul-gtest is being linked and
|
|
# dump-sym'ed.
|
|
ifneq (,$(filter toolkit/library/gtest/rust/target,$(compile_targets)))
|
|
toolkit/library/rust/target: toolkit/library/gtest/rust/target
|
|
endif
|
|
endif
|