mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-24 13:21:05 +00:00
1a62550191
This is a simple mistake of the previous patch. The code path is originally for a left click handling. Therefore, there is no check whether the click point is in a selection range because in that case, left click should collapse selection. However, the selection should not be collapse when it's a right click in a selection range because the context menu target is the selection range. The `ui.mouse.right_click.collapse_selection.stop_if_non_collapsed_selection` pref is set to `true` by default. Therefore, the existence of a non-collapsed selection has hidden this bug. However, if it's set to `false`, this always happens. Additionally, editor does not set ancestor limiter of selection if the root element is editable [1]. I think that we can now remove this special path, but it's risky. Therefore, this patch just adds the new check into the method. 1. https://searchfox.org/mozilla-central/rev/ce4599d3d4e20e34cb6db68f255c3dff1aec246b/editor/libeditor/EditorBase.cpp#5448,5450-5451 Differential Revision: https://phabricator.services.mozilla.com/D193529 |
||
|---|---|---|
| .. | ||
| composer | ||
| docs | ||
| libeditor | ||
| reftests | ||
| spellchecker | ||
| txmgr | ||
| AsyncSpellCheckTestHelper.sys.mjs | ||
| moz.build | ||
| nsIDocumentStateListener.idl | ||
| nsIEditActionListener.idl | ||
| nsIEditor.idl | ||
| nsIEditorMailSupport.idl | ||
| nsIEditorSpellCheck.idl | ||
| nsIHTMLAbsPosEditor.idl | ||
| nsIHTMLEditor.idl | ||
| nsIHTMLInlineTableEditor.idl | ||
| nsIHTMLObjectResizer.idl | ||
| nsITableEditor.idl | ||