gecko-dev/chrome
Nicholas Nethercote 9252435548 Bug 1410794 (attempt 2) - Change some |string| occurrences in nsIPrefBranch.idl to |ACString|. r=erahm.
This makes the code nicer. In particular, it removes many getter_Copies()
calls. The patch also converts a lot of nsCStrings to nsAutoCString, which will
avoid heap allocation in the common case.

The patch also renames PREF_CopyCharPref() as PREF_GetCStringPref(), because
it's actually getting a string, not a char, and that matches the existing
GetCString() and GetDefaultCString() methods. Correspondingly, it also renames
PREF_SetCharPref() as PREF_SetCStringPref().

The |aPrefName| arguments in nsIPrefBranch.idl remain as |string| because they
almost always involve passing in C string literals, and passing "foo" is much
nicer than passing NS_LITERAL_CSTRING("foo").

It's worth noting that early versions of this patch used |AUTF8String| instead
of |ACString|. But it turns out that libpref stores prefs internally as Latin1.
And |ACString| is compatible with Latin1 but |AUTF8String| isn't, because
non-ASCII Latin1 strings are not valid UTF-8!

MozReview-Commit-ID: D3f7a1Vl1oE

--HG--
extra : rebase_source : e6e4b15d6d210cfd93686f96400281f02bd1d06b
2017-10-27 10:30:33 +11:00
..
test Bug 1403956 - Enable ESLint from chrome/ directory. r=standard8 2017-10-26 16:56:18 -04:00
moz.build Bug 1328388 - add BUG_COMPONENT to chrome/* files. r=bsmedberg 2017-01-06 11:33:44 -05:00
nsChromeProtocolHandler.cpp Bug 1326520 - Rename nsIURI.path to pathQueryRef. r=valentin.gosu 2017-07-29 20:50:21 +09:00
nsChromeProtocolHandler.h
nsChromeRegistry.cpp Bug 1402860 - Remove ENABLE_INTL_API conditional from nsChromeRegistry. r=smaug 2017-09-25 17:32:34 +01:00
nsChromeRegistry.h Bug 780562 - Remove support for the chrome "platform" flag. r=bsmedberg 2017-04-14 20:48:53 +09:00
nsChromeRegistryChrome.cpp Bug 1410794 (attempt 2) - Change some |string| occurrences in nsIPrefBranch.idl to |ACString|. r=erahm. 2017-10-27 10:30:33 +11:00
nsChromeRegistryChrome.h Bug 1347306 - Hand over language negotiation from ChromeRegistry to LocaleService. r=jfkthame 2017-03-14 15:28:47 -07:00
nsChromeRegistryContent.cpp Backed out changeset 05fc8d2d7ca9 (bug 863246) for failing various reftests, e.g. parser/htmlparser/tests/reftest/bug535530-2.html. r=backout on a CLOSED TREE 2017-08-25 16:44:40 +02:00
nsChromeRegistryContent.h Bug 1347306 - Hand over language negotiation from ChromeRegistry to LocaleService. r=jfkthame 2017-03-14 15:28:47 -07:00
nsIChromeRegistry.idl Bug 1312049 - Switch nsChromeRegistry::GetDirectionForLocale to use uloc_isRightToLeft instead of a list of known-rtl locales, and replace the now-obsolete intl.uidirection.* prefs with a single override intl.uidirection for testing purposes. r=gandalf 2017-02-02 22:12:50 +00:00
nsIToolkitChromeRegistry.idl
RegistryMessageUtils.h Backed out changeset 05fc8d2d7ca9 (bug 863246) for failing various reftests, e.g. parser/htmlparser/tests/reftest/bug535530-2.html. r=backout on a CLOSED TREE 2017-08-25 16:44:40 +02:00