gecko-dev/widget/android
Chris Peterson 0958fa945a Bug 1878465 - Change Android event error string from char8_t to char to fix C++20 build error. r=geckoview-reviewers,m_kato
When compiled with -std=c++17, `u8""` string literals have type `const char[]`. When compiled with -std=c++20, `u8""` strings have type `const char8_t[]`. `JS_ReportErrorUTF8()` has no override for `char8_t` strings, so `u8"Invalid event data property %s"` at https://searchfox.org/mozilla-central/rev/5eedf36dc46f1683af7478c7adaf308ceb42911b/widget/android/EventDispatcher.cpp#132 fails to compile. In this case, there's no reason for `"Invalid event data property %s"` to be a `u8` string because it contains no non-ASCII characters that would be encoded incorrectly. Plus, clang's default character encoding for .cpp files is UTF-8, so `u8` is redundant here.

widget/android/EventDispatcher.cpp:125:7: error: no matching function for call to 'JS_ReportErrorUTF8'
  125 |       JS_ReportErrorUTF8(
      |       ^~~~~~~~~~~~~~~~~~
obj-aarch64-unknown-linux-android/dist/include/js/ErrorReport.h:465:27: note: candidate function not viable: no known conversion from 'const char8_t[31]' to 'const char *' for 2nd argument
  465 | extern JS_PUBLIC_API void JS_ReportErrorUTF8(JSContext* cx, const char* format,
      |                           ^                                 ~~~~~~~~~~~~~~~~~~

Differential Revision: https://phabricator.services.mozilla.com/D200553
2024-02-22 17:40:21 +00:00
..
bindings Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
jni
AndroidAlerts.cpp
AndroidAlerts.h
AndroidBridge.cpp
AndroidBridge.h
AndroidBridgeUtilities.h
AndroidCompositorWidget.cpp
AndroidCompositorWidget.h
AndroidContentController.cpp
AndroidContentController.h
AndroidUiThread.cpp
AndroidUiThread.h
AndroidView.h
AndroidVsync.cpp
AndroidVsync.h
AndroidWidgetUtils.cpp Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
AndroidWidgetUtils.h Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
Base64UtilsSupport.h
components.conf Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
CompositorWidgetChild.cpp
CompositorWidgetChild.h
CompositorWidgetParent.cpp
CompositorWidgetParent.h
EventDispatcher.cpp Bug 1878465 - Change Android event error string from char8_t to char to fix C++20 build error. r=geckoview-reviewers,m_kato 2024-02-22 17:40:21 +00:00
EventDispatcher.h
GeckoBatteryManager.h
GeckoEditableSupport.cpp
GeckoEditableSupport.h
GeckoNetworkManager.h
GeckoProcessManager.cpp
GeckoProcessManager.h
GeckoSystemStateListener.h
GeckoTelemetryDelegate.h
GeckoViewSupport.h
GeckoVRManager.h
GfxInfo.cpp Bug 1868737 - Allow minimal gfx features by default for uncertain configurations. r=jrmuizel,perftest-reviewers,kshampur 2024-01-05 22:23:25 +00:00
GfxInfo.h
ImageDecoderSupport.cpp
ImageDecoderSupport.h
InProcessAndroidCompositorWidget.cpp
InProcessAndroidCompositorWidget.h
MediaKeysEventSourceFactory.cpp
moz.build Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
nsAppShell.cpp Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
nsAppShell.h
nsClipboard.cpp Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
nsClipboard.h Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
nsDeviceContextAndroid.cpp
nsDeviceContextAndroid.h
nsDragService.cpp Bug 1878599 - Allow to insert text on text control from dropping external application on Geckoview. r=masayuki,geckoview-reviewers,owlish 2024-02-14 00:58:48 +00:00
nsDragService.h Bug 1586471 - Part 3. Allow to drop data from external application on GeckoView. r=dom-core,geckoview-reviewers,amejiamarmol,edgar 2024-01-28 07:49:53 +00:00
nsIAndroidBridge.idl
nsLookAndFeel.cpp Bug 1881488 - Use a static pref for tooltip delay. r=masayuki,dom-core 2024-02-22 12:59:41 +00:00
nsLookAndFeel.h
nsPrintSettingsServiceAndroid.cpp
nsPrintSettingsServiceAndroid.h
nsUserIdleServiceAndroid.cpp
nsUserIdleServiceAndroid.h
nsWidgetFactory.cpp
nsWidgetFactory.h
nsWindow.cpp Bug 1878599 - Allow to insert text on text control from dropping external application on Geckoview. r=masayuki,geckoview-reviewers,owlish 2024-02-14 00:58:48 +00:00
nsWindow.h Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
PCompositorWidget.ipdl
PlatformWidgetTypes.ipdlh
ScreenHelperAndroid.cpp
ScreenHelperAndroid.h
Telemetry.h Bug 1877576 - Migrate geckoview GVST probes r=geckoview-reviewers,perry.mcmanis,owlish 2024-02-09 21:11:05 +00:00
WebExecutorSupport.cpp Bug 1586471 - Part 2. Implement nsDragService on GeckoView. r=geckoview-reviewers,amejiamarmol 2024-01-28 07:49:53 +00:00
WebExecutorSupport.h
WindowEvent.h