mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-31 22:25:30 +00:00
fc07e38ecd
The eyedropper can be shown in 2 distinct ways: - the 'eyedropper' gcli command can be called (from the dev toolboar or from the browser devtools menu), - or the inspector's 'pickColorFromPage' method can be called (from the inspector toolbar or from the color-picker in the ruleview). Before this change, it was possible to show several eyedropper because these 2 codepaths didn't know about each other. Now, when executing the gcli command, the inspector's 'cancelPickColorFromPage' method is called to hide it first. And, when the 'pickColorFromPage' method is called, the 'eyedropper --hide' gcli command is called too. This way, there's only one eyedropper shown. There was also a problem where the gcli command would create a new eyedropper everytime it was called. This was fixed too, by maintaining a WeakMap of all eyedroppers opened so far. MozReview-Commit-ID: F6fBP5R7ZTJ --HG-- extra : rebase_source : f04bbf224ced7b93b4e5b0c42662731ecc58cb58 |
||
|---|---|---|
| .. | ||
| client | ||
| docs | ||
| server | ||
| shared | ||
| .eslintrc | ||
| .eslintrc.mochitests | ||
| .eslintrc.xpcshell | ||
| bootstrap.js | ||
| chrome.manifest | ||
| install.rdf | ||
| moz.build | ||
| templates.mozbuild | ||