mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-27 06:43:32 +00:00
786351922e
We have RemoteAccessible::mParent and RemoteAccessible::mDoc, so DocAccessibleParent::mParentDoc was redundant. Aside from the redundancy, this was one extra thing we needed to keep up to date and reason about. This involved changing the call to RemoveChildDoc in Destroy to use Unbind instead because Unbind clears the parent RemoteAccessible, but RemoveChildDoc didn't. That meant we had a dangling RemoteAccessible::mParent pointer, which was always a problem, but is more problematic now that we no longer have mParentDoc and the destructor checks the parent document. Since Unbind is the only caller of RemoveChildDoc, RemoveChildDoc has been merged into Unbind. This means there is now only a single place where child documents are unbound from their parent, which should make things easier to reason about. Differential Revision: https://phabricator.services.mozilla.com/D218802 |
||
|---|---|---|
| .. | ||
| DocAccessibleChild.cpp | ||
| DocAccessibleChild.h | ||
| DocAccessibleParent.cpp | ||
| DocAccessibleParent.h | ||
| DocAccessibleTypes.ipdlh | ||
| IPCTypes.h | ||
| moz.build | ||
| PDocAccessible.ipdl | ||
| RemoteAccessible.cpp | ||
| RemoteAccessible.h | ||