gecko-dev/toolkit/components/downloads/DownloadPaths.jsm
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00

142 lines
6.1 KiB
JavaScript

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/**
* Provides methods for giving names and paths to files being downloaded.
*/
"use strict";
var EXPORTED_SYMBOLS = [
"DownloadPaths",
];
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
ChromeUtils.defineModuleGetter(this, "AppConstants",
"resource://gre/modules/AppConstants.jsm");
/**
* Platform-dependent regular expression used by the "sanitize" method.
*/
XPCOMUtils.defineLazyGetter(this, "gConvertToSpaceRegExp", () => {
/* eslint-disable no-control-regex */
switch (AppConstants.platform) {
// On mobile devices, the file system may be very limited in what it
// considers valid characters. To avoid errors, sanitize conservatively.
case "android":
return /[\x00-\x1f\x7f-\x9f:*?|"<>;,+=\[\]]+/g;
case "win":
return /[\x00-\x1f\x7f-\x9f:*?|]+/g;
case "macosx":
return /[\x00-\x1f\x7f-\x9f:]+/g;
default:
return /[\x00-\x1f\x7f-\x9f]+/g;
}
/* eslint-enable no-control-regex */
});
var DownloadPaths = {
/**
* Sanitizes an arbitrary string for use as the local file name of a download.
* The input is often a document title or a manually edited name. The output
* can be an empty string if the input does not include any valid character.
*
* The length of the resulting string is not limited, because restrictions
* apply to the full path name after the target folder has been added.
*
* Splitting the base name and extension to add a counter or to identify the
* file type should only be done after the sanitization process, because it
* can alter the final part of the string or remove leading dots.
*
* Runs of slashes and backslashes are replaced with an underscore.
*
* On Windows, the angular brackets `<` and `>` are replaced with parentheses,
* and double quotes are replaced with single quotes.
*
* Runs of control characters are replaced with a space. On Mac, colons are
* also included in this group. On Windows, stars, question marks, and pipes
* are additionally included. On Android, semicolons, commas, plus signs,
* equal signs, and brackets are additionally included.
*
* Leading and trailing dots and whitespace are removed on all platforms. This
* avoids the accidental creation of hidden files on Unix and invalid or
* inaccessible file names on Windows. These characters are not removed when
* located at the end of the base name or at the beginning of the extension.
*/
sanitize(leafName) {
if (AppConstants.platform == "win") {
leafName = leafName.replace(/</g, "(")
.replace(/>/g, ")")
.replace(/"/g, "'");
}
return leafName.replace(/[\\/]+/g, "_")
.replace(/[\u200e\u200f\u202a-\u202e]/g, "")
.replace(gConvertToSpaceRegExp, " ")
.replace(/^[\s\u180e.]+|[\s\u180e.]+$/g, "");
},
/**
* Creates a uniquely-named file starting from the name of the provided file.
* If a file with the provided name already exists, the function attempts to
* create nice alternatives, like "base(1).ext" (instead of "base-1.ext").
*
* If a unique name cannot be found, the function throws the XPCOM exception
* NS_ERROR_FILE_TOO_BIG. Other exceptions, like NS_ERROR_FILE_ACCESS_DENIED,
* can also be expected.
*
* @param templateFile
* nsIFile whose leaf name is going to be used as a template. The
* provided object is not modified.
*
* @return A new instance of an nsIFile object pointing to the newly created
* empty file. On platforms that support permission bits, the file is
* created with permissions 644.
*/
createNiceUniqueFile(templateFile) {
// Work on a clone of the provided template file object.
let curFile = templateFile.clone().QueryInterface(Ci.nsIFile);
let [base, ext] = DownloadPaths.splitBaseNameAndExtension(curFile.leafName);
// Try other file names, for example "base(1).txt" or "base(1).tar.gz",
// only if the file name initially set already exists.
for (let i = 1; i < 10000 && curFile.exists(); i++) {
curFile.leafName = base + "(" + i + ")" + ext;
}
// At this point we hand off control to createUnique, which will create the
// file with the name we chose, if it is valid. If not, createUnique will
// attempt to modify it again, for example it will shorten very long names
// that can't be created on some platforms, and for which a normal call to
// nsIFile.create would result in NS_ERROR_FILE_NOT_FOUND. This can result
// very rarely in strange names like "base(9999).tar-1.gz" or "ba-1.gz".
curFile.createUnique(Ci.nsIFile.NORMAL_FILE_TYPE, 0o644);
return curFile;
},
/**
* Separates the base name from the extension in a file name, recognizing some
* double extensions like ".tar.gz".
*
* @param leafName
* The full leaf name to be parsed. Be careful when processing names
* containing leading or trailing dots or spaces.
*
* @return [base, ext]
* The base name of the file, which can be empty, and its extension,
* which always includes the leading dot unless it's an empty string.
* Concatenating the two items always results in the original name.
*/
splitBaseNameAndExtension(leafName) {
// The following regular expression is built from these key parts:
// .*? Matches the base name non-greedily.
// \.[A-Z0-9]{1,3} Up to three letters or numbers preceding a
// double extension.
// \.(?:gz|bz2|Z) The second part of common double extensions.
// \.[^.]* Matches any extension or a single trailing dot.
let [, base, ext] = /(.*?)(\.[A-Z0-9]{1,3}\.(?:gz|bz2|Z)|\.[^.]*)?$/i
.exec(leafName);
// Return an empty string instead of undefined if no extension is found.
return [base, ext || ""];
},
};