mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 16:25:38 +00:00
0d4a611a04
MozReview-Commit-ID: AXrQEjWzxvg --HG-- extra : rebase_source : bf972fbb22648af2edbb756eb899ebddf8444dbc
35 lines
1.4 KiB
C++
35 lines
1.4 KiB
C++
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "RefCountedCopyConstructorChecker.h"
|
|
#include "CustomMatchers.h"
|
|
|
|
void RefCountedCopyConstructorChecker::registerMatchers(
|
|
MatchFinder *AstMatcher) {
|
|
AstMatcher->addMatcher(
|
|
cxxConstructExpr(
|
|
hasDeclaration(cxxConstructorDecl(isCompilerProvidedCopyConstructor(),
|
|
ofClass(hasRefCntMember()))))
|
|
.bind("node"),
|
|
this);
|
|
}
|
|
|
|
void RefCountedCopyConstructorChecker::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const char *Error =
|
|
"Invalid use of compiler-provided copy constructor on refcounted type";
|
|
const char *Note = "The default copy constructor also copies the "
|
|
"default mRefCnt property, leading to reference "
|
|
"count imbalance issues. Please provide your own "
|
|
"copy constructor which only copies the fields which "
|
|
"need to be copied";
|
|
|
|
// Everything we needed to know was checked in the matcher - we just report
|
|
// the error here
|
|
const CXXConstructExpr *E = Result.Nodes.getNodeAs<CXXConstructExpr>("node");
|
|
|
|
diag(E->getLocation(), Error, DiagnosticIDs::Error);
|
|
diag(E->getLocation(), Note, DiagnosticIDs::Note);
|
|
}
|