Nathan Froyd cfb8fb313f Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg ... This patch was generated by running: ``` perl -p -i \ -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \ -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \ $FILE ``` against every .cpp and .h in mozilla-central, and then fixing up the inevitable errors that happen as a result of matching C++ expressions with regexes. The errors fell into three categories: 1. Calling the convert functions with `std::string::c_str()`; these were changed to simply pass the string instead, relying on implicit conversion to `mozilla::Span`. 2. Calling the convert functions with raw pointers, which is not permitted with the copy functions; these were changed to invoke `MakeStringSpan` first. 3. Other miscellaneous errors resulting from over-eager regexes and/or the replacement not being type-aware. These changes were reverted. Differential Revision: https://phabricator.services.mozilla.com/D88903		2020-09-02 09:54:37 +00:00
..
build	Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi	2020-07-09 21:42:25 +00:00
rust
test	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
variant
FileSystemModule.cpp
FileSystemModule.h
IStorageBindingParamsInternal.h
moz.build	Bug 1620198 - Part 4: Remove mozIStorageAggregateFunction. r=asuth	2020-06-08 10:00:31 +00:00
mozIStorageAsyncConnection.idl	Bug 1620198 - Part 1: Remove CreateAggregateFunction. r=asuth	2020-06-08 09:59:57 +00:00
mozIStorageAsyncStatement.idl
mozIStorageBaseStatement.idl
mozIStorageBindingParams.idl
mozIStorageBindingParamsArray.idl
mozIStorageCompletionCallback.idl
mozIStorageConnection.idl
mozIStorageError.idl
mozIStorageFunction.idl
mozIStoragePendingStatement.idl
mozIStorageProgressHandler.idl
mozIStorageResultSet.idl
mozIStorageRow.idl
mozIStorageService.idl	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozIStorageStatement.idl
mozIStorageStatementCallback.idl
mozIStorageVacuumParticipant.idl
mozIStorageValueArray.idl
mozStorageArgValueArray.cpp
mozStorageArgValueArray.h
mozStorageAsyncStatement.cpp	Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj	2020-07-01 08:29:29 +00:00
mozStorageAsyncStatement.h
mozStorageAsyncStatementExecution.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageAsyncStatementExecution.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageAsyncStatementJSHelper.cpp
mozStorageAsyncStatementJSHelper.h
mozStorageAsyncStatementParams.cpp
mozStorageAsyncStatementParams.h
mozStorageBindingParams.cpp
mozStorageBindingParams.h
mozStorageBindingParamsArray.cpp
mozStorageBindingParamsArray.h
mozStorageConnection.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageConnection.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageError.cpp
mozStorageError.h
mozStorageHelper.h	Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj	2020-07-01 08:29:29 +00:00
mozStoragePrivateHelpers.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStoragePrivateHelpers.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageResultSet.cpp
mozStorageResultSet.h
mozStorageRow.cpp
mozStorageRow.h
mozStorageService.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageService.h	Bug 1650201 - Fix mozStorage prefs read before profile and fallback to a non-exclusive VFS when it can't get an exclusive lock. r=asuth,geckoview-reviewers,agi	2020-07-10 21:45:53 +00:00
mozStorageSQLFunctions.cpp
mozStorageSQLFunctions.h
mozStorageStatement.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageStatement.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageStatementData.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageStatementJSHelper.cpp
mozStorageStatementJSHelper.h
mozStorageStatementParams.cpp
mozStorageStatementParams.h
mozStorageStatementRow.cpp
mozStorageStatementRow.h
SQLCollations.cpp
SQLCollations.h
SQLiteMutex.h
StatementCache.h
storage.h
StorageBaseStatementInternal.cpp	Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj	2020-08-04 11:27:07 +00:00
StorageBaseStatementInternal.h
style.txt
TelemetryVFS.cpp	Bug 1650201 - Fix mozStorage prefs read before profile and fallback to a non-exclusive VFS when it can't get an exclusive lock. r=asuth,geckoview-reviewers,agi	2020-07-10 21:45:53 +00:00
VacuumManager.cpp	Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg	2020-09-02 09:54:37 +00:00
VacuumManager.h
Variant_inl.h
Variant.cpp
Variant.h
variantToSQLiteT_impl.h