mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-22 09:45:41 +00:00
e930b89c34
*** Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8 This changes the behavior of ChromeUtils.import() to return an exports object, rather than a module global, in all cases except when `null` is passed as a second argument, and changes the default behavior not to pollute the global scope with the module's exports. Thus, the following code written for the old model: ChromeUtils.import("resource://gre/modules/Services.jsm"); is approximately the same as the following, in the new model: var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm"); Since the two behaviors are mutually incompatible, this patch will land with a scripted rewrite to update all existing callers to use the new model rather than the old. *** Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs This was done using the followng script: https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm *** Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D16747 *** Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16748 *** Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16749 *** Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs *** Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D16750 --HG-- extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895 extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
116 lines
3.3 KiB
JavaScript
116 lines
3.3 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
var EXPORTED_SYMBOLS = [ "AboutNewTab" ];
|
|
|
|
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
XPCOMUtils.defineLazyModuleGetters(this, {
|
|
ActivityStream: "resource://activity-stream/lib/ActivityStream.jsm",
|
|
RemotePages: "resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm",
|
|
});
|
|
|
|
const BROWSER_READY_NOTIFICATION = "sessionstore-windows-restored";
|
|
|
|
var AboutNewTab = {
|
|
QueryInterface: ChromeUtils.generateQI([Ci.nsIObserver, Ci.nsISupportsWeakReference]),
|
|
|
|
// AboutNewTab
|
|
|
|
pageListener: null,
|
|
|
|
isOverridden: false,
|
|
|
|
activityStream: null,
|
|
|
|
/**
|
|
* init - Initializes an instance of Activity Stream if one doesn't exist already
|
|
* and creates the instance of Remote Page Manager which Activity Stream
|
|
* uses for message passing.
|
|
*
|
|
* @param {obj} pageListener - Optional argument. An existing instance of RemotePages
|
|
* which Activity Stream has previously made, and we
|
|
* would like to re-use.
|
|
*/
|
|
init(pageListener) {
|
|
if (this.isOverridden) {
|
|
return;
|
|
}
|
|
|
|
// Since `init` can be called via `reset` at a later time with an existing
|
|
// pageListener, we want to only add the observer if we are initializing
|
|
// without this pageListener argument. This means it was the first call to `init`
|
|
if (!pageListener) {
|
|
Services.obs.addObserver(this, BROWSER_READY_NOTIFICATION);
|
|
}
|
|
|
|
this.pageListener = pageListener || new RemotePages(["about:home", "about:newtab", "about:welcome"]);
|
|
},
|
|
|
|
/**
|
|
* onBrowserReady - Continues the initialization of Activity Stream after browser is ready.
|
|
*/
|
|
onBrowserReady() {
|
|
if (this.activityStream && this.activityStream.initialized) {
|
|
return;
|
|
}
|
|
|
|
this.activityStream = new ActivityStream();
|
|
try {
|
|
this.activityStream.init();
|
|
} catch (e) {
|
|
Cu.reportError(e);
|
|
}
|
|
},
|
|
|
|
/**
|
|
* uninit - Uninitializes Activity Stream if it exists, and destroys the pageListener
|
|
* if it exists.
|
|
*/
|
|
uninit() {
|
|
if (this.activityStream) {
|
|
this.activityStream.uninit();
|
|
this.activityStream = null;
|
|
}
|
|
|
|
if (this.pageListener) {
|
|
this.pageListener.destroy();
|
|
this.pageListener = null;
|
|
}
|
|
},
|
|
|
|
override(shouldPassPageListener) {
|
|
this.isOverridden = true;
|
|
const pageListener = this.pageListener;
|
|
if (!pageListener)
|
|
return null;
|
|
if (shouldPassPageListener) {
|
|
this.pageListener = null;
|
|
return pageListener;
|
|
}
|
|
this.uninit();
|
|
return null;
|
|
},
|
|
|
|
reset(pageListener) {
|
|
this.isOverridden = false;
|
|
this.init(pageListener);
|
|
},
|
|
|
|
// nsIObserver implementation
|
|
|
|
observe(subject, topic, data) {
|
|
switch (topic) {
|
|
case BROWSER_READY_NOTIFICATION:
|
|
Services.obs.removeObserver(this, BROWSER_READY_NOTIFICATION);
|
|
// Avoid running synchronously during this event that's used for timing
|
|
Services.tm.dispatchToMainThread(() => this.onBrowserReady());
|
|
break;
|
|
}
|
|
},
|
|
};
|