gecko-dev/widget/nsIWidgetListener.cpp
Emilio Cobos Álvarez fb6380190c Bug 1786525 - Don't update untransformed anchor rect when moved by move-to-rect. r=stransky
Otherwise, it changes the move-to-rect inputs, which can change the
output as well, making us move the anchor all the way to the right.

You could, I guess, consider this a mutter bug of sorts, because it
feels weird that you pass it an anchor that has been a `move-to-rect`
output and you get another rect as an output.

But also, it's kinda silly that we're doing that to begin with, so avoid
it by telling the popup frame whether it's been positioned / moved by
move-to-rect (and keeping the anchor in that case).

The reason this works on my setup without "Large text" is just dumb luck
(the front-end computes a max-height for the panel that is small enough
to fit on the screen).

Differential Revision: https://phabricator.services.mozilla.com/D155406
2022-08-30 09:30:27 +00:00

94 lines
2.9 KiB
C++

/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "nsIWidgetListener.h"
#include "nsRegion.h"
#include "nsView.h"
#include "nsIWidget.h"
#include "nsIAppWindow.h"
#include "mozilla/BasicEvents.h"
#include "mozilla/PresShell.h"
using namespace mozilla;
nsIAppWindow* nsIWidgetListener::GetAppWindow() { return nullptr; }
nsView* nsIWidgetListener::GetView() { return nullptr; }
PresShell* nsIWidgetListener::GetPresShell() { return nullptr; }
bool nsIWidgetListener::WindowMoved(nsIWidget* aWidget, int32_t aX, int32_t aY,
ByMoveToRect) {
return false;
}
bool nsIWidgetListener::WindowResized(nsIWidget* aWidget, int32_t aWidth,
int32_t aHeight) {
return false;
}
void nsIWidgetListener::SizeModeChanged(nsSizeMode aSizeMode) {}
void nsIWidgetListener::SafeAreaInsetsChanged(const mozilla::ScreenIntMargin&) {
}
void nsIWidgetListener::UIResolutionChanged() {}
#if defined(MOZ_WIDGET_ANDROID)
void nsIWidgetListener::DynamicToolbarMaxHeightChanged(ScreenIntCoord aHeight) {
}
void nsIWidgetListener::DynamicToolbarOffsetChanged(ScreenIntCoord aOffset) {}
#endif
void nsIWidgetListener::FullscreenWillChange(bool aInFullscreen) {}
void nsIWidgetListener::FullscreenChanged(bool aInFullscreen) {}
void nsIWidgetListener::MacFullscreenMenubarOverlapChanged(
mozilla::DesktopCoord aOverlapAmount) {}
bool nsIWidgetListener::ZLevelChanged(bool aImmediate, nsWindowZ* aPlacement,
nsIWidget* aRequestBelow,
nsIWidget** aActualBelow) {
return false;
}
void nsIWidgetListener::OcclusionStateChanged(bool aIsFullyOccluded) {}
void nsIWidgetListener::WindowActivated() {}
void nsIWidgetListener::WindowDeactivated() {}
void nsIWidgetListener::OSToolbarButtonPressed() {}
bool nsIWidgetListener::RequestWindowClose(nsIWidget* aWidget) { return false; }
void nsIWidgetListener::WillPaintWindow(nsIWidget* aWidget) {}
bool nsIWidgetListener::PaintWindow(nsIWidget* aWidget,
LayoutDeviceIntRegion aRegion) {
return false;
}
void nsIWidgetListener::DidPaintWindow() {}
void nsIWidgetListener::DidCompositeWindow(
mozilla::layers::TransactionId aTransactionId,
const TimeStamp& aCompositeStart, const TimeStamp& aCompositeEnd) {}
void nsIWidgetListener::RequestRepaint() {}
bool nsIWidgetListener::ShouldNotBeVisible() {
// Returns false to assume that nothing should happen in most cases.
return false;
}
nsEventStatus nsIWidgetListener::HandleEvent(WidgetGUIEvent* aEvent,
bool aUseAttachedEvents) {
return nsEventStatus_eIgnore;
}