2017-12-12 16:54:20 +00:00
|
|
|
import os
|
|
|
|
import platform
|
|
|
|
import re
|
|
|
|
import subprocess
|
2019-10-31 16:51:53 +00:00
|
|
|
import sys
|
2022-03-17 22:22:17 +00:00
|
|
|
|
|
|
|
# TODO: LooseVersion is undocumented; use something else.
|
|
|
|
from distutils.version import LooseVersion
|
2017-12-12 16:54:20 +00:00
|
|
|
|
|
|
|
import lit.formats
|
|
|
|
import lit.util
|
|
|
|
|
|
|
|
from lit.llvm import llvm_config
|
|
|
|
from lit.llvm.subst import ToolSubst
|
|
|
|
|
|
|
|
# Configuration file for the 'lit' test runner.
|
|
|
|
|
|
|
|
# name: The name of this test suite.
|
2021-02-11 15:41:32 +00:00
|
|
|
config.name = "cross-project-tests"
|
2017-12-12 16:54:20 +00:00
|
|
|
|
|
|
|
# testFormat: The test format to use to interpret tests.
|
|
|
|
config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
|
|
|
|
|
|
|
|
# suffixes: A list of file extensions to treat as test files.
|
2023-02-16 10:10:54 +00:00
|
|
|
config.suffixes = [".c", ".cl", ".cpp", ".m"]
|
2017-12-12 16:54:20 +00:00
|
|
|
|
|
|
|
# excludes: A list of directories to exclude from the testsuite. The 'Inputs'
|
|
|
|
# subdirectories contain auxiliary inputs for various tests in their parent
|
|
|
|
# directories.
|
|
|
|
config.excludes = ["Inputs"]
|
|
|
|
|
|
|
|
# test_source_root: The root path where tests are located.
|
2021-02-11 15:41:32 +00:00
|
|
|
config.test_source_root = config.cross_project_tests_src_root
|
2017-12-12 16:54:20 +00:00
|
|
|
|
|
|
|
# test_exec_root: The root path where tests should be run.
|
2021-02-11 15:41:32 +00:00
|
|
|
config.test_exec_root = config.cross_project_tests_obj_root
|
2017-12-12 16:54:20 +00:00
|
|
|
|
2019-10-31 16:51:53 +00:00
|
|
|
llvm_config.use_default_substitutions()
|
|
|
|
|
2019-05-28 23:03:33 +00:00
|
|
|
tools = [
|
|
|
|
ToolSubst(
|
|
|
|
"%test_debuginfo",
|
|
|
|
command=os.path.join(
|
2021-02-11 15:41:32 +00:00
|
|
|
config.cross_project_tests_src_root,
|
|
|
|
"debuginfo-tests",
|
2021-02-08 15:40:55 +00:00
|
|
|
"llgdb-tests",
|
|
|
|
"test_debuginfo.pl",
|
|
|
|
),
|
2023-05-17 14:59:41 +00:00
|
|
|
),
|
2020-01-11 07:47:41 +00:00
|
|
|
ToolSubst("%llvm_src_root", config.llvm_src_root),
|
|
|
|
ToolSubst("%llvm_tools_dir", config.llvm_tools_dir),
|
2019-05-28 23:03:33 +00:00
|
|
|
]
|
|
|
|
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2019-05-28 23:03:33 +00:00
|
|
|
def get_required_attr(config, attr_name):
|
|
|
|
attr_value = getattr(config, attr_name, None)
|
|
|
|
if attr_value == None:
|
|
|
|
lit_config.fatal(
|
|
|
|
"No attribute %r in test configuration! You may need to run "
|
|
|
|
"tests from your build directory or add this attribute "
|
|
|
|
"to lit.site.cfg " % attr_name
|
|
|
|
)
|
|
|
|
return attr_value
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2019-05-28 23:03:33 +00:00
|
|
|
|
|
|
|
# If this is an MSVC environment, the tests at the root of the tree are
|
|
|
|
# unsupported. The local win_cdb test suite, however, is supported.
|
|
|
|
is_msvc = get_required_attr(config, "is_msvc")
|
|
|
|
if is_msvc:
|
2019-10-31 16:51:53 +00:00
|
|
|
config.available_features.add("msvc")
|
2019-05-28 23:03:33 +00:00
|
|
|
# FIXME: We should add some llvm lit utility code to find the Windows SDK
|
|
|
|
# and set up the environment appopriately.
|
|
|
|
win_sdk = "C:/Program Files (x86)/Windows Kits/10/"
|
|
|
|
arch = "x64"
|
|
|
|
llvm_config.with_system_environment(["LIB", "LIBPATH", "INCLUDE"])
|
|
|
|
# Clear _NT_SYMBOL_PATH to prevent cdb from attempting to load symbols from
|
|
|
|
# the network.
|
|
|
|
llvm_config.with_environment("_NT_SYMBOL_PATH", "")
|
|
|
|
tools.append(
|
|
|
|
ToolSubst("%cdb", '"%s"' % os.path.join(win_sdk, "Debuggers", arch, "cdb.exe"))
|
|
|
|
)
|
|
|
|
|
2021-02-09 14:57:03 +00:00
|
|
|
# clang_src_dir and lld_src_dir are not used by these tests, but are required by
|
|
|
|
# use_clang() and use_lld() respectively, so set them to "", if needed.
|
2017-12-12 16:54:20 +00:00
|
|
|
if not hasattr(config, "clang_src_dir"):
|
|
|
|
config.clang_src_dir = ""
|
2024-01-19 03:59:09 +00:00
|
|
|
llvm_config.use_clang(required=("clang" in config.llvm_enabled_projects))
|
2021-02-09 15:19:27 +00:00
|
|
|
|
2021-02-09 14:57:03 +00:00
|
|
|
if not hasattr(config, "lld_src_dir"):
|
|
|
|
config.lld_src_dir = ""
|
|
|
|
llvm_config.use_lld(required=("lld" in config.llvm_enabled_projects))
|
2017-12-12 16:54:20 +00:00
|
|
|
|
2022-02-09 17:08:43 +00:00
|
|
|
if "compiler-rt" in config.llvm_enabled_projects:
|
|
|
|
config.available_features.add("compiler-rt")
|
|
|
|
|
2021-12-16 13:41:29 +00:00
|
|
|
# Check which debuggers are available:
|
|
|
|
lldb_path = llvm_config.use_llvm_tool("lldb", search_env="LLDB")
|
|
|
|
|
|
|
|
if lldb_path is not None:
|
|
|
|
config.available_features.add("lldb")
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-12-16 13:41:29 +00:00
|
|
|
|
|
|
|
def configure_dexter_substitutions():
|
|
|
|
"""Configure substitutions for host platform and return list of dependencies"""
|
|
|
|
# Produce dexter path, lldb path, and combine into the %dexter substitution
|
|
|
|
# for running a test.
|
|
|
|
dexter_path = os.path.join(
|
|
|
|
config.cross_project_tests_src_root, "debuginfo-tests", "dexter", "dexter.py"
|
|
|
|
)
|
|
|
|
dexter_test_cmd = '"{}" "{}" test'.format(sys.executable, dexter_path)
|
|
|
|
if lldb_path is not None:
|
|
|
|
dexter_test_cmd += ' --lldb-executable "{}"'.format(lldb_path)
|
|
|
|
tools.append(ToolSubst("%dexter", dexter_test_cmd))
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-12-16 13:41:29 +00:00
|
|
|
# For testing other bits of dexter that aren't under the "test" subcommand,
|
|
|
|
# have a %dexter_base substitution.
|
|
|
|
dexter_base_cmd = '"{}" "{}"'.format(sys.executable, dexter_path)
|
|
|
|
tools.append(ToolSubst("%dexter_base", dexter_base_cmd))
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-12-16 13:41:29 +00:00
|
|
|
# Set up commands for DexTer regression tests.
|
|
|
|
# Builder, debugger, optimisation level and several other flags differ
|
|
|
|
# depending on whether we're running a unix like or windows os.
|
|
|
|
if platform.system() == "Windows":
|
|
|
|
# The Windows builder script uses lld.
|
|
|
|
dependencies = ["clang", "lld-link"]
|
2023-09-05 15:04:53 +00:00
|
|
|
dexter_regression_test_builder = "clang-cl"
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
dexter_regression_test_debugger = "dbgeng"
|
2023-09-05 15:04:53 +00:00
|
|
|
dexter_regression_test_flags = "/Zi /Od"
|
2021-12-16 13:41:29 +00:00
|
|
|
else:
|
|
|
|
# Use lldb as the debugger on non-Windows platforms.
|
|
|
|
dependencies = ["clang", "lldb"]
|
2023-09-05 15:04:53 +00:00
|
|
|
dexter_regression_test_builder = "clang++"
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
dexter_regression_test_debugger = "lldb"
|
2023-09-05 15:04:53 +00:00
|
|
|
dexter_regression_test_flags = "-O0 -glldb -std=gnu++11"
|
2023-05-17 14:59:41 +00:00
|
|
|
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
tools.append(
|
|
|
|
ToolSubst("%dexter_regression_test_builder", dexter_regression_test_builder)
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
tools.append(
|
|
|
|
ToolSubst("%dexter_regression_test_debugger", dexter_regression_test_debugger)
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
2023-09-05 15:04:53 +00:00
|
|
|
# We don't need to distinguish cflags and ldflags because for Dexter
|
|
|
|
# regression tests we use clang to drive the linker, and so all flags will be
|
|
|
|
# passed in a single command.
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
tools.append(
|
2023-09-05 15:04:53 +00:00
|
|
|
ToolSubst("%dexter_regression_test_flags", dexter_regression_test_flags)
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
|
|
|
|
2021-12-16 13:41:29 +00:00
|
|
|
# Typical command would take the form:
|
2023-09-05 15:04:53 +00:00
|
|
|
# ./path_to_py/python.exe ./path_to_dex/dexter.py test --fail-lt 1.0 -w --binary %t --debugger lldb --cflags '-O0 -g'
|
|
|
|
dexter_regression_test_run = " ".join(
|
2021-12-16 13:41:29 +00:00
|
|
|
# "python", "dexter.py", test, fail_mode, builder, debugger, cflags, ldflags
|
|
|
|
[
|
|
|
|
'"{}"'.format(sys.executable),
|
|
|
|
'"{}"'.format(dexter_path),
|
|
|
|
"test",
|
|
|
|
"--fail-lt 1.0 -w",
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
"--debugger",
|
|
|
|
dexter_regression_test_debugger,
|
2023-05-17 14:59:41 +00:00
|
|
|
]
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
)
|
2023-09-05 15:04:53 +00:00
|
|
|
tools.append(ToolSubst("%dexter_regression_test_run", dexter_regression_test_run))
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-12-16 13:41:29 +00:00
|
|
|
# Include build flags for %dexter_regression_test.
|
|
|
|
dexter_regression_test_build = " ".join(
|
|
|
|
[
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
dexter_regression_test_builder,
|
2023-09-05 15:04:53 +00:00
|
|
|
dexter_regression_test_flags,
|
2023-05-17 14:59:41 +00:00
|
|
|
]
|
[Dexter] Remove false requirement of lldb for dexter regression tests on Windows
Not quite NFC because a little work was required to configure some tests to run
on Windows at all.
Before this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported: 49
Passed : 23
After this patch on Windows:
$ llvm-lit cross-project-tests\debuginfo-tests\dexter\feature-tests
Unsupported : 27
Passed : 39
Expectedly failed: 6
There are 3 main changes here. The first is to add a few more substitutions in
cross-project-tests/lit.cfg.py so that tests need to use specific flags can
still use the dexter regression test defaults for the native platform. These
are:
%dexter_regression_test_debugger
%dexter_regression_test_builder
%dexter_regression_test_cflags
%dexter_regression_test_ldflags
Tests that now use these options and therefore can be run on Windows too
(though the second is still failing for unknown reasons):
cross-project-tests/debuginfo-tests/dexte/feature_tests
/subtools/clang-opt-bisect/clang-opt-bisect.cpp
/subtools/test/source-root-dir.cpp
The second change is to remove spurious `REQUIRES: system-linux, lldb` and
`UNSUPPORTED: system-windows` directives, and make changes to lit.local.cfg
files that have the same effect. I've also added comments to the genuine
REQUIRES, UNSUPPORTED, and XFAIL directives so it's easier to understand
requirements at a glance. The most common reason for a test to not be supported
on Windows is that it uses DexLimitSteps, DexDeclareAddress, or DexCommandLine,
none of which are supported in the dbgeng driver.
There are two failures on Windows that were previously hidden, which I've
XFAILed:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_conditional.cpp
/commands/perfect/dex_finish_test/default_conditional_hit_count.cpp
And two that were easy to fix:
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/dex_finish_test/default_simple.cpp
/commands/perfect/dex_finish_test/default_hit_count.cpp
Lastly, I've set three directories as unsupported.
cross-project-tests/debuginfo-tests/dexter/feature_tests
/commands/perfect/limit_steps
/commands/perfect/dex_declare_address
/commands/perfect/dex_declare_file
The first two are unsupported on Windows because they contains tests for the
DexLimitSteps and DexDeclareAddress commands which aren't supported in the
dbgeng driver. The third is unsupported on all platforms as the tests involve
invoking clang directly, which isn't currently a supported way of building
tests for dexter in lit (it can cause problems for cross compilers that can
target the host, as the tests use the default triple and linker, which may
be aligned for the default target, not host).
Tested on Windows and Linux.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D118048
2022-01-26 11:09:21 +00:00
|
|
|
)
|
2023-09-05 15:04:53 +00:00
|
|
|
tools.append(ToolSubst("%dexter_regression_test_build", dexter_regression_test_build))
|
2021-12-16 13:41:29 +00:00
|
|
|
return dependencies
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-12-16 13:41:29 +00:00
|
|
|
|
2021-02-24 11:09:18 +00:00
|
|
|
def add_host_triple(clang):
|
|
|
|
return "{} --target={}".format(clang, config.host_triple)
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-02-24 11:09:18 +00:00
|
|
|
|
|
|
|
# The set of arches we can build.
|
|
|
|
targets = set(config.targets_to_build)
|
|
|
|
# Add aliases to the target set.
|
|
|
|
if "AArch64" in targets:
|
|
|
|
targets.add("arm64")
|
|
|
|
if "ARM" in config.targets_to_build:
|
|
|
|
targets.add("thumbv7")
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-02-24 11:09:18 +00:00
|
|
|
|
|
|
|
def can_target_host():
|
|
|
|
# Check if the targets set contains anything that looks like our host arch.
|
|
|
|
# The arch name in the triple and targets set may be spelled differently
|
|
|
|
# (e.g. x86 vs X86).
|
|
|
|
return any(config.host_triple.lower().startswith(x.lower()) for x in targets)
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2021-02-24 11:09:18 +00:00
|
|
|
|
|
|
|
# Dexter tests run on the host machine. If the host arch is supported add
|
|
|
|
# 'dexter' as an available feature and force the dexter tests to use the host
|
|
|
|
# triple.
|
|
|
|
if can_target_host():
|
|
|
|
if config.host_triple != config.target_triple:
|
|
|
|
print("Forcing dexter tests to use host triple {}.".format(config.host_triple))
|
2021-12-16 13:41:29 +00:00
|
|
|
dependencies = configure_dexter_substitutions()
|
|
|
|
if all(d in config.available_features for d in dependencies):
|
|
|
|
config.available_features.add("dexter")
|
|
|
|
llvm_config.with_environment(
|
|
|
|
"PATHTOCLANG", add_host_triple(llvm_config.config.clang)
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
2021-12-16 13:41:29 +00:00
|
|
|
llvm_config.with_environment(
|
|
|
|
"PATHTOCLANGPP", add_host_triple(llvm_config.use_llvm_tool("clang++"))
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
2021-12-16 13:41:29 +00:00
|
|
|
llvm_config.with_environment(
|
|
|
|
"PATHTOCLANGCL", add_host_triple(llvm_config.use_llvm_tool("clang-cl"))
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
2021-02-24 11:09:18 +00:00
|
|
|
else:
|
|
|
|
print(
|
|
|
|
"Host triple {} not supported. Skipping dexter tests in the "
|
|
|
|
"debuginfo-tests project.".format(config.host_triple)
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
2019-10-31 16:51:53 +00:00
|
|
|
|
2017-12-12 16:54:20 +00:00
|
|
|
tool_dirs = [config.llvm_tools_dir]
|
|
|
|
|
|
|
|
llvm_config.add_tool_substitutions(tools, tool_dirs)
|
|
|
|
|
|
|
|
lit.util.usePlatformSdkOnDarwin(config, lit_config)
|
2018-08-04 00:02:48 +00:00
|
|
|
|
|
|
|
if platform.system() == "Darwin":
|
2019-06-25 15:58:32 +00:00
|
|
|
xcode_lldb_vers = subprocess.check_output(["xcrun", "lldb", "--version"]).decode(
|
|
|
|
"utf-8"
|
|
|
|
)
|
2018-08-04 00:02:48 +00:00
|
|
|
match = re.search("lldb-(\d+)", xcode_lldb_vers)
|
|
|
|
if match:
|
|
|
|
apple_lldb_vers = int(match.group(1))
|
|
|
|
if apple_lldb_vers < 1000:
|
|
|
|
config.available_features.add("apple-lldb-pre-1000")
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2019-10-31 16:51:53 +00:00
|
|
|
|
2022-02-09 10:47:07 +00:00
|
|
|
def get_gdb_version_string():
|
|
|
|
"""Return gdb's version string, or None if gdb cannot be found or the
|
|
|
|
--version output is formatted unexpectedly.
|
|
|
|
"""
|
|
|
|
# See if we can get a gdb version, e.g.
|
|
|
|
# $ gdb --version
|
|
|
|
# GNU gdb (GDB) 10.2
|
|
|
|
# ...More stuff...
|
|
|
|
try:
|
|
|
|
gdb_vers_lines = (
|
|
|
|
subprocess.check_output(["gdb", "--version"]).decode().splitlines()
|
2023-05-17 14:59:41 +00:00
|
|
|
)
|
2022-02-09 10:47:07 +00:00
|
|
|
except:
|
|
|
|
return None # We coudln't find gdb or something went wrong running it.
|
|
|
|
if len(gdb_vers_lines) < 1:
|
|
|
|
print("Unkown GDB version format (too few lines)", file=sys.stderr)
|
|
|
|
return None
|
2022-02-09 11:32:29 +00:00
|
|
|
match = re.search("GNU gdb \(.*?\) ((\d|\.)+)", gdb_vers_lines[0].strip())
|
|
|
|
if match is None:
|
|
|
|
print(f"Unkown GDB version format: {gdb_vers_lines[0]}", file=sys.stderr)
|
2022-02-09 10:47:07 +00:00
|
|
|
return None
|
2022-02-09 11:32:29 +00:00
|
|
|
return match.group(1)
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2022-02-09 10:47:07 +00:00
|
|
|
|
|
|
|
def get_clang_default_dwarf_version_string(triple):
|
|
|
|
"""Return the default dwarf version string for clang on this (host) platform
|
|
|
|
or None if we can't work it out.
|
|
|
|
"""
|
|
|
|
# Get the flags passed by the driver and look for -dwarf-version.
|
|
|
|
cmd = f'{llvm_config.use_llvm_tool("clang")} -g -xc -c - -v -### --target={triple}'
|
|
|
|
stderr = subprocess.run(cmd.split(), stderr=subprocess.PIPE).stderr.decode()
|
|
|
|
match = re.search("-dwarf-version=(\d+)", stderr)
|
|
|
|
if match is None:
|
|
|
|
print("Cannot determine default dwarf version", file=sys.stderr)
|
|
|
|
return None
|
|
|
|
return match.group(1)
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2022-02-09 10:47:07 +00:00
|
|
|
|
|
|
|
# Some cross-project-tests use gdb, but not all versions of gdb are compatible
|
|
|
|
# with clang's dwarf. Add feature `gdb-clang-incompatibility` to signal that
|
|
|
|
# there's an incompatibility between clang's default dwarf version for this
|
|
|
|
# platform and the installed gdb version.
|
|
|
|
dwarf_version_string = get_clang_default_dwarf_version_string(config.host_triple)
|
|
|
|
gdb_version_string = get_gdb_version_string()
|
|
|
|
if dwarf_version_string and gdb_version_string:
|
|
|
|
if int(dwarf_version_string) >= 5:
|
2022-03-17 22:22:17 +00:00
|
|
|
if LooseVersion(gdb_version_string) < LooseVersion("10.1"):
|
2022-02-09 10:47:07 +00:00
|
|
|
# Example for llgdb-tests, which use lldb on darwin but gdb elsewhere:
|
|
|
|
# XFAIL: !system-darwin && gdb-clang-incompatibility
|
|
|
|
config.available_features.add("gdb-clang-incompatibility")
|
|
|
|
print(
|
|
|
|
"XFAIL some tests: use gdb version >= 10.1 to restore test coverage",
|
|
|
|
file=sys.stderr,
|
|
|
|
)
|
2023-05-17 14:59:41 +00:00
|
|
|
|
2020-09-29 13:19:54 +00:00
|
|
|
llvm_config.feature_config([("--build-mode", {"Debug|RelWithDebInfo": "debug-info"})])
|
2022-03-17 22:22:17 +00:00
|
|
|
|
|
|
|
# Allow 'REQUIRES: XXX-registered-target' in tests.
|
|
|
|
for arch in config.targets_to_build:
|
|
|
|
config.available_features.add(arch.lower() + "-registered-target")
|