Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-01-19 14:44:39 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[OpenMP][DeviceRTL] Fixed an issue that causes hang in SU3

Browse Source 
The synchronization at the end of parallel region cannot make sure all threads
exit the scope. As a result, the assertions right after it might be hit, and
further the `state::assumeInitialState(IsSPMD)` in `__kmpc_target_deinit` may
not hold as well. We either add a synchronization right after the parallel region,
or remove the assertions and assuptions. Here we choose the first one as those
assertions and assumptions can help optimizations.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D112861
This commit is contained in:
Shilei Tian 2021-10-30 14:43:59 -04:00
parent 931d20c5db
commit 025f549240
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openmp/libomptarget/DeviceRTL/src/Parallelism.cpp
View File

@ -123,6 +123,11 @@ void __kmpc_parallel_51(IdentTy *ident, int32_t, int32_t if_expr,
synchronize::threadsAligned();
}
// Synchronize all threads to make sure every thread exits the scope above;
// otherwise the following assertions and the assumption in
// __kmpc_target_deinit may not hold.
synchronize::threadsAligned();
ASSERT(state::ParallelTeamSize == 1u);
ASSERT(icv::ActiveLevel == 0u);
ASSERT(icv::Level == 0u);