Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-23 22:00:10 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[DAG] Set nneg flag when forming zext in demanded bits (#72281)

Browse Source 
We do the same for the analogous transform in DAGCombine, but this case
was missed in the recent patch which added support for zext nneg.

Sorry for the lack of test coverage. Not sure how to exercise this piece
of logic. It appears to have only minimal impact on LIT tests (only
test/CodeGen/X86/wide-scalar-shift-by-byte-multiple-legalization.ll),
and even then, the changes without it appear uninteresting. Maybe we
should remove this transform instead?
This commit is contained in:
Philip Reames 2024-01-18 07:34:08 -08:00 committed by GitHub
parent 2747193058
commit 0fc5f4b524
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
View File

@ -2483,8 +2483,12 @@ bool TargetLowering::SimplifyDemandedBits(
if (Known.isNonNegative()) {
unsigned Opc =
IsVecInReg ? ISD::ZERO_EXTEND_VECTOR_INREG : ISD::ZERO_EXTEND;
if (!TLO.LegalOperations() || isOperationLegal(Opc, VT))
return TLO.CombineTo(Op, TLO.DAG.getNode(Opc, dl, VT, Src));
if (!TLO.LegalOperations() || isOperationLegal(Opc, VT)) {
SDNodeFlags Flags;
if (!IsVecInReg)
Flags.setNonNeg(true);
return TLO.CombineTo(Op, TLO.DAG.getNode(Opc, dl, VT, Src, Flags));
}
}
// Attempt to avoid multi-use ops if we don't need anything from them.