Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-24 14:20:17 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Force GHashCell to be 8-byte-aligned.

Browse Source 
Otherwise, with recent versions of libstdc++, clang can't tell that the
atomic operations are properly aligned, and generates calls to
libatomic.  (Actually, because of the use of reinterpret_cast, it wasn't
guaranteed to be aligned, but I think it ended up being aligned in
practice.)

Fixes https://github.com/llvm/llvm-project/issues/54790 , the part where
LLVM failed to build.

Differential Revision: https://reviews.llvm.org/D123872
This commit is contained in:
Eli Friedman 2022-04-15 13:03:39 -07:00
parent daa6d7b250
commit 13fc178173
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lld/COFF/DebugTypes.cpp
View File

@ -902,7 +902,11 @@ struct GHashTable {
/// A ghash table cell for deduplicating types from TpiSources.
class GHashCell {
uint64_t data = 0;
// Force "data" to be 64-bit aligned; otherwise, some versions of clang
// will generate calls to libatomic when using some versions of libstdc++
// on 32-bit targets. (Also, in theory, there could be a target where
// new[] doesn't always return an 8-byte-aligned allocation.)
alignas(sizeof(uint64_t)) uint64_t data = 0;
public:
GHashCell() = default;