[LAA] Re-check bit-width of pointers after stripping.

Summary:
- As the pointer stripping now tracks through `addrspacecast`, prepare
  to handle the bit-width difference from the result pointer.

Reviewers: jdoerfert

Subscribers: jvesely, nhaehnle, hiraditya, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64928

llvm-svn: 366470
This commit is contained in:
Michael Liao 2019-07-18 17:30:27 +00:00
parent 2e97a1e19e
commit 17a8a9277c
2 changed files with 27 additions and 1 deletions

View File

@ -1189,12 +1189,25 @@ bool llvm::isConsecutiveAccess(Value *A, Value *B, const DataLayout &DL,
unsigned IdxWidth = DL.getIndexSizeInBits(ASA);
Type *Ty = cast<PointerType>(PtrA->getType())->getElementType();
APInt Size(IdxWidth, DL.getTypeStoreSize(Ty));
APInt OffsetA(IdxWidth, 0), OffsetB(IdxWidth, 0);
PtrA = PtrA->stripAndAccumulateInBoundsConstantOffsets(DL, OffsetA);
PtrB = PtrB->stripAndAccumulateInBoundsConstantOffsets(DL, OffsetB);
// Retrieve the address space again as pointer stripping now tracks through
// `addrspacecast`.
ASA = cast<PointerType>(PtrA->getType())->getAddressSpace();
ASB = cast<PointerType>(PtrB->getType())->getAddressSpace();
// Check that the address spaces match and that the pointers are valid.
if (ASA != ASB)
return false;
IdxWidth = DL.getIndexSizeInBits(ASA);
OffsetA = OffsetA.sextOrTrunc(IdxWidth);
OffsetB = OffsetB.sextOrTrunc(IdxWidth);
APInt Size(IdxWidth, DL.getTypeStoreSize(Ty));
// OffsetDelta = OffsetB - OffsetA;
const SCEV *OffsetSCEVA = SE.getConstant(OffsetA);
const SCEV *OffsetSCEVB = SE.getConstant(OffsetB);

View File

@ -147,3 +147,16 @@ bb:
store i32 %sub1, i32* undef
ret void
}
; CHECK-LABEL: slp_crash_on_addrspacecast
; CHECK: ret void
define void @slp_crash_on_addrspacecast() {
entry:
%0 = getelementptr inbounds i64, i64 addrspace(3)* undef, i32 undef
%p0 = addrspacecast i64 addrspace(3)* %0 to i64*
store i64 undef, i64* %p0, align 8
%1 = getelementptr inbounds i64, i64 addrspace(3)* undef, i32 undef
%p1 = addrspacecast i64 addrspace(3)* %1 to i64*
store i64 undef, i64* %p1, align 8
ret void
}