From 1d568bf9605c05ff088b244d7894ab2d88da9811 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 17 Jan 2020 19:04:06 -0500 Subject: [PATCH] Remove AllTargetsAsmPrinters It's been an empty target since r360498 and friends (`git log --grep='Move InstPrinter files to MCTargetDesc.' llvm/lib/Target`), but due to hwo the way these targets are structured it was silently an empty target without anyone noticing. No behavior change. --- llvm/cmake/modules/LLVM-Config.cmake | 7 ------- llvm/docs/BuildingADistribution.rst | 1 - llvm/tools/dsymutil/CMakeLists.txt | 1 - llvm/tools/llvm-cfi-verify/CMakeLists.txt | 1 - llvm/tools/llvm-mc-assemble-fuzzer/CMakeLists.txt | 1 - llvm/tools/llvm-mc-disassemble-fuzzer/CMakeLists.txt | 1 - llvm/tools/llvm-mc/CMakeLists.txt | 1 - llvm/tools/llvm-mca/CMakeLists.txt | 1 - llvm/tools/llvm-ml/CMakeLists.txt | 1 - llvm/tools/llvm-objdump/CMakeLists.txt | 1 - llvm/tools/sancov/CMakeLists.txt | 1 - llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt | 1 - 12 files changed, 18 deletions(-) diff --git a/llvm/cmake/modules/LLVM-Config.cmake b/llvm/cmake/modules/LLVM-Config.cmake index c3fa59e83358..76d4d3e8dbba 100644 --- a/llvm/cmake/modules/LLVM-Config.cmake +++ b/llvm/cmake/modules/LLVM-Config.cmake @@ -171,13 +171,6 @@ function(llvm_expand_pseudo_components out_components) list(APPEND expanded_components "${t}CodeGen") endif() endforeach(t) - elseif( c STREQUAL "AllTargetsAsmPrinters" ) - # Link all the asm printers from all the targets - foreach(t ${LLVM_TARGETS_TO_BUILD}) - if( TARGET LLVM${t}AsmPrinter ) - list(APPEND expanded_components "${t}AsmPrinter") - endif() - endforeach(t) elseif( c STREQUAL "AllTargetsAsmParsers" ) # Link all the asm parsers from all the targets foreach(t ${LLVM_TARGETS_TO_BUILD}) diff --git a/llvm/docs/BuildingADistribution.rst b/llvm/docs/BuildingADistribution.rst index 9ad6fc2f7bc0..4be86bef9033 100644 --- a/llvm/docs/BuildingADistribution.rst +++ b/llvm/docs/BuildingADistribution.rst @@ -194,7 +194,6 @@ that are already documented include: *LLVM_TARGETS_TO_BUILD*, #. ``all`` - All LLVM available component libraries #. ``Native`` - The LLVM target for the Native system - #. ``AllTargetsAsmPrinters`` - All the included target ASM printers libraries #. ``AllTargetsAsmParsers`` - All the included target ASM parsers libraries #. ``AllTargetsDescs`` - All the included target descriptions libraries #. ``AllTargetsDisassemblers`` - All the included target dissassemblers libraries diff --git a/llvm/tools/dsymutil/CMakeLists.txt b/llvm/tools/dsymutil/CMakeLists.txt index fecd8a61ad00..a6543c9ff2ce 100644 --- a/llvm/tools/dsymutil/CMakeLists.txt +++ b/llvm/tools/dsymutil/CMakeLists.txt @@ -3,7 +3,6 @@ tablegen(LLVM Options.inc -gen-opt-parser-defs) add_public_tablegen_target(DsymutilTableGen) set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsCodeGens AllTargetsDescs AllTargetsInfos diff --git a/llvm/tools/llvm-cfi-verify/CMakeLists.txt b/llvm/tools/llvm-cfi-verify/CMakeLists.txt index ae12bec5e807..647c2f733f29 100644 --- a/llvm/tools/llvm-cfi-verify/CMakeLists.txt +++ b/llvm/tools/llvm-cfi-verify/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsAsmParsers AllTargetsDescs AllTargetsDisassemblers diff --git a/llvm/tools/llvm-mc-assemble-fuzzer/CMakeLists.txt b/llvm/tools/llvm-mc-assemble-fuzzer/CMakeLists.txt index fb6befd3c54a..d92fdb6137ac 100644 --- a/llvm/tools/llvm-mc-assemble-fuzzer/CMakeLists.txt +++ b/llvm/tools/llvm-mc-assemble-fuzzer/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsAsmParsers AllTargetsDescs AllTargetsInfos diff --git a/llvm/tools/llvm-mc-disassemble-fuzzer/CMakeLists.txt b/llvm/tools/llvm-mc-disassemble-fuzzer/CMakeLists.txt index e055e0c6d917..d1fbdf4c6989 100644 --- a/llvm/tools/llvm-mc-disassemble-fuzzer/CMakeLists.txt +++ b/llvm/tools/llvm-mc-disassemble-fuzzer/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsDescs AllTargetsDisassemblers AllTargetsInfos diff --git a/llvm/tools/llvm-mc/CMakeLists.txt b/llvm/tools/llvm-mc/CMakeLists.txt index 15c6dda1b258..a18783e828b8 100644 --- a/llvm/tools/llvm-mc/CMakeLists.txt +++ b/llvm/tools/llvm-mc/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsAsmParsers AllTargetsDescs AllTargetsDisassemblers diff --git a/llvm/tools/llvm-mca/CMakeLists.txt b/llvm/tools/llvm-mca/CMakeLists.txt index 4b18075f9869..9918cd8c8dc6 100644 --- a/llvm/tools/llvm-mca/CMakeLists.txt +++ b/llvm/tools/llvm-mca/CMakeLists.txt @@ -1,7 +1,6 @@ include_directories(include) set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsAsmParsers AllTargetsDescs AllTargetsDisassemblers diff --git a/llvm/tools/llvm-ml/CMakeLists.txt b/llvm/tools/llvm-ml/CMakeLists.txt index 44976d9feecd..74546385e2c5 100644 --- a/llvm/tools/llvm-ml/CMakeLists.txt +++ b/llvm/tools/llvm-ml/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsAsmParsers AllTargetsDescs AllTargetsDisassemblers diff --git a/llvm/tools/llvm-objdump/CMakeLists.txt b/llvm/tools/llvm-objdump/CMakeLists.txt index 001fcb399fa6..d8f320e83196 100644 --- a/llvm/tools/llvm-objdump/CMakeLists.txt +++ b/llvm/tools/llvm-objdump/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsDescs AllTargetsDisassemblers AllTargetsInfos diff --git a/llvm/tools/sancov/CMakeLists.txt b/llvm/tools/sancov/CMakeLists.txt index 2a7707289335..51d8db67b5ae 100644 --- a/llvm/tools/sancov/CMakeLists.txt +++ b/llvm/tools/sancov/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsDescs AllTargetsDisassemblers AllTargetsInfos diff --git a/llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt b/llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt index 8f865463de1b..ee89c9b5ad92 100644 --- a/llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt +++ b/llvm/unittests/tools/llvm-cfi-verify/CMakeLists.txt @@ -1,5 +1,4 @@ set(LLVM_LINK_COMPONENTS - AllTargetsAsmPrinters AllTargetsAsmParsers AllTargetsDescs AllTargetsDisassemblers