objc - in matching setter argument type to its property type,

ingore the type qualifiers. // rdar://10156674

llvm-svn: 140571
This commit is contained in:
Fariborz Jahanian 2011-09-26 22:12:27 +00:00
parent a6a9c20c23
commit 23ef165920
2 changed files with 37 additions and 1 deletions

View File

@ -1481,7 +1481,8 @@ void Sema::ProcessPropertyDecl(ObjCPropertyDecl *property,
Context.VoidTy)
Diag(SetterMethod->getLocation(), diag::err_setter_type_void);
if (SetterMethod->param_size() != 1 ||
((*SetterMethod->param_begin())->getType() != property->getType())) {
((*SetterMethod->param_begin())->getType().getUnqualifiedType()
!= property->getType().getUnqualifiedType())) {
Diag(property->getLocation(),
diag::warn_accessor_property_type_mismatch)
<< property->getDeclName()

View File

@ -0,0 +1,35 @@
// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fobjc-nonfragile-abi -fsyntax-only -fobjc-arc -fblocks -verify %s
// rdar://10156674
@class NSArray;
@interface MyClass2 {
@private
NSArray *_names1;
NSArray *_names2;
NSArray *_names3;
NSArray *_names4;
}
@property (readwrite, strong) NSArray *names1; // <-- warning: Type of property....
- (void)setNames1:(NSArray *)names;
@property (readwrite, strong) __strong NSArray *names2; // <-- warning: Type of property....
- (void)setNames2:(NSArray *)names;
@property (readwrite, strong) __strong NSArray *names3; // <-- OK
- (void)setNames3:(__strong NSArray *)names;
@property (readwrite, strong) NSArray *names4; // <-- warning: Type of property....
- (void)setNames4:(__strong NSArray *)names;
@end
@implementation MyClass2
- (NSArray *)names1 { return _names1; }
- (void)setNames1:(NSArray *)names {}
- (NSArray *)names2 { return _names2; }
- (void)setNames2:(NSArray *)names {}
- (NSArray *)names3 { return _names3; }
- (void)setNames3:(__strong NSArray *)names {}
- (NSArray *)names4 { return _names4; }
- (void)setNames4:(__strong NSArray *)names {}
@end