Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-03-04 16:41:43 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

ProfDataUtils: Add extractFromBranchWeightMD function; NFC

Browse Source 
Expose internal helper function as new `extractFromBranchWeightMD` API.

Differential revision: https://reviews.llvm.org/D157937
This commit is contained in:
Matthias Braun 2023-08-14 16:53:13 -07:00
parent f8431a0e40
commit 285e0235f5
2 changed files with 25 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/include/llvm/IR/ProfDataUtils.h
View File

@ -64,6 +64,11 @@ MDNode *getValidBranchWeightMDNode(const Instruction &I);
bool extractBranchWeights(const MDNode *ProfileData,
SmallVectorImpl<uint32_t> &Weights);
/// Faster version of extractBranchWeights() that skips checks and must only
/// be called with "branch_weights" metadata nodes.
void extractFromBranchWeightMD(const MDNode *ProfileData,
SmallVectorImpl<uint32_t> &Weights);
/// Extract branch weights attatched to an Instruction
///
/// \param I The Instruction to extract weights from.

41
llvm/lib/IR/ProfDataUtils.cpp
View File

@ -45,26 +45,6 @@ constexpr unsigned WeightsIdx = 1;
// the minimum number of operands for MD_prof nodes with branch weights
constexpr unsigned MinBWOps = 3;
bool extractWeights(const MDNode *ProfileData,
SmallVectorImpl<uint32_t> &Weights) {
// Assume preconditions are already met (i.e. this is valid metadata)
assert(ProfileData && "ProfileData was nullptr in extractWeights");
unsigned NOps = ProfileData->getNumOperands();
assert(WeightsIdx < NOps && "Weights Index must be less than NOps.");
Weights.resize(NOps - WeightsIdx);
for (unsigned Idx = WeightsIdx, E = NOps; Idx != E; ++Idx) {
ConstantInt *Weight =
mdconst::dyn_extract<ConstantInt>(ProfileData->getOperand(Idx));
assert(Weight && "Malformed branch_weight in MD_prof node");
assert(Weight->getValue().getActiveBits() <= 32 &&
"Too many bits for uint32_t");
Weights[Idx - WeightsIdx] = Weight->getZExtValue();
}
return true;
}
// We may want to add support for other MD_prof types, so provide an abstraction
// for checking the metadata type.
bool isTargetMD(const MDNode *ProfData, const char *Name, unsigned MinOps) {
@ -119,11 +99,30 @@ MDNode *getValidBranchWeightMDNode(const Instruction &I) {
return nullptr;
}
void extractFromBranchWeightMD(const MDNode *ProfileData,
SmallVectorImpl<uint32_t> &Weights) {
assert(isBranchWeightMD(ProfileData) && "wrong metadata");
unsigned NOps = ProfileData->getNumOperands();
assert(WeightsIdx < NOps && "Weights Index must be less than NOps.");
Weights.resize(NOps - WeightsIdx);
for (unsigned Idx = WeightsIdx, E = NOps; Idx != E; ++Idx) {
ConstantInt *Weight =
mdconst::dyn_extract<ConstantInt>(ProfileData->getOperand(Idx));
assert(Weight && "Malformed branch_weight in MD_prof node");
assert(Weight->getValue().getActiveBits() <= 32 &&
"Too many bits for uint32_t");
Weights[Idx - WeightsIdx] = Weight->getZExtValue();
}
}
bool extractBranchWeights(const MDNode *ProfileData,
SmallVectorImpl<uint32_t> &Weights) {
if (!isBranchWeightMD(ProfileData))
return false;
return extractWeights(ProfileData, Weights);
extractFromBranchWeightMD(ProfileData, Weights);
return true;
}
bool extractBranchWeights(const Instruction &I,