Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2024-11-27 15:41:46 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[lldb] Replace radars link with documenting comment (NFC)

Browse Source 
This replaces two radar links with improved comments explaining the
underlying issues.

 - The first issue is working around a compiler bug that was fixed in
   f454dfb6b5.
 - The second issue is an invariant that doesn't actually hold. The
   latter was marked as FIXME but there was nothing in the radar about a
   possible alternative solution.

Both radars were closed.
This commit is contained in:
Jonas Devlieghere 2023-07-30 15:14:33 -07:00
parent 949d4d1602
commit 2fcade935a
No known key found for this signature in database
GPG Key ID: 49CC0BD90FDEED4D
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
View File

@ -1171,16 +1171,17 @@ TypeSP DWARFASTParserClang::ParseSubroutine(const DWARFDIE &die,
class_type->GetFullCompilerType();
// The type for this DIE should have been filled in the
// function call above
// function call above.
Type *type_ptr = dwarf->GetDIEToType()[die.GetDIE()];
if (type_ptr && type_ptr != DIE_IS_BEING_PARSED) {
return type_ptr->shared_from_this();
}
// FIXME This is fixing some even uglier behavior but we
// really need to
// uniq the methods of each class as well as the class
// itself. <rdar://problem/11240464>
// The previous comment isn't actually true if the class wasn't
// resolved using the current method's parent DIE as source
// data. We need to ensure that we look up the method correctly
// in the class and then link the method's DIE to the unique
// CXXMethodDecl appropriately.
type_handled = true;
}
}
@ -2950,12 +2951,10 @@ void DWARFASTParserClang::ParseSingleMember(
member_clang_type.GetCompleteType();
{
// Older versions of clang emit array[0] and array[1] in the
// same way (<rdar://problem/12566646>). If the current field
// is at the end of the structure, then there is definitely no
// room for extra elements and we override the type to
// array[0].
// Older versions of clang emit the same DWARF for array[0] and array[1]. If
// the current field is at the end of the structure, then there is
// definitely no room for extra elements and we override the type to
// array[0]. This was fixed by f454dfb6b5af.
CompilerType member_array_element_type;
uint64_t member_array_size;
bool member_array_is_incomplete;