From 37e54f454af0f337ffa13c70d2ba260c9811a522 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 22 Aug 2007 05:16:28 +0000 Subject: [PATCH] Fix a nasty C99 scope issue that Neil pointed out (for ifs) This fixes test/Parser/control-scope.c llvm-svn: 41263 --- clang/Parse/ParseStmt.cpp | 14 ++++++++++++++ clang/test/Parser/control-scope.c | 8 ++++++++ 2 files changed, 22 insertions(+) create mode 100644 clang/test/Parser/control-scope.c diff --git a/clang/Parse/ParseStmt.cpp b/clang/Parse/ParseStmt.cpp index 6784f166c9e3..f96da44623ef 100644 --- a/clang/Parse/ParseStmt.cpp +++ b/clang/Parse/ParseStmt.cpp @@ -433,6 +433,10 @@ Parser::StmtResult Parser::ParseIfStatement() { return true; } + // In C99, the body of the if statement is a scope, even if there is no + // compound stmt. + if (getLang().C99) EnterScope(0); + // Read the if condition. StmtResult CondStmt = ParseStatement(); @@ -440,13 +444,23 @@ Parser::StmtResult Parser::ParseIfStatement() { if (CondStmt.isInvalid) CondStmt = Actions.ParseNullStmt(Tok.getLocation()); + // Pop the 'if' scope if needed. + if (getLang().C99) ExitScope(); // If it has an else, parse it. SourceLocation ElseLoc; StmtResult ElseStmt(false); if (Tok.getKind() == tok::kw_else) { ElseLoc = ConsumeToken(); + + // In C99, the body of the if statement is a scope, even if there is no + // compound stmt. + if (getLang().C99) EnterScope(0); + ElseStmt = ParseStatement(); + + // Pop the 'else' scope if needed. + if (getLang().C99) ExitScope(); if (ElseStmt.isInvalid) ElseStmt = Actions.ParseNullStmt(ElseLoc); diff --git a/clang/test/Parser/control-scope.c b/clang/test/Parser/control-scope.c new file mode 100644 index 000000000000..62f79dbdf173 --- /dev/null +++ b/clang/test/Parser/control-scope.c @@ -0,0 +1,8 @@ +// RUN: not clang %s -std=c90 +// RUN: clang %s -std=c99 + +int f (int z) { + if (z + sizeof (enum {a})) + return 1 + sizeof (enum {a}); + return 0; +}