Magic-Mirror/llvm-capstone
1
0
Fork 0
mirror of https://github.com/capstone-engine/llvm-capstone.git synced 2025-04-01 12:43:47 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

[LCG] Replace an implicit bool operator with a named function. (NFC)

Browse Source 
The definition of 'false' here was already pretty vague and debatable,
and I'm about to add another potential 'false' that would actually make
much more sense in a bool operator. Especially given how rarely this is
used, a nicely named method seems better.

llvm-svn: 310165
This commit is contained in:
Chandler Carruth 2017-08-05 04:04:06 +00:00
parent 403d3c4b2b
commit 39df40d8c2
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/include/llvm/Analysis/LazyCallGraph.h
View File

@ -329,7 +329,7 @@ public:
bool operator!=(const Node &N) const { return !operator==(N); }
/// Tests whether the node has been populated with edges.
operator bool() const { return Edges.hasValue(); }
bool isPopulated() const { return Edges.hasValue(); }
// We allow accessing the edges by dereferencing or using the arrow
// operator, essentially wrapping the internal optional.

4
llvm/lib/Analysis/LazyCallGraph.cpp
View File

@ -212,7 +212,7 @@ void LazyCallGraph::SCC::verify() {
assert(N->LowLink == -1 &&
"Must set low link to -1 when adding a node to an SCC!");
for (Edge &E : **N)
assert(E.getNode() && "Can't have an unpopulated node!");
assert(E.getNode().isPopulated() && "Can't have an unpopulated node!");
}
}
#endif
@ -1649,7 +1649,7 @@ void LazyCallGraph::removeDeadFunction(Function &F) {
for (RefSCC &ParentRC : RC.parents())
for (SCC &ParentC : ParentRC)
for (Node &ParentN : ParentC)
if (ParentN)
if (ParentN.isPopulated())
ParentN->removeEdgeInternal(N);
// Now remove this RefSCC from any parents sets and the leaf list.